`Compute` - Fix failed Acc Test #27465

ms-zhenhua · 2024-09-23T08:17:13Z

Community Note

Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Fix failed acc tests of VM and VMSS.

PR Checklist

I have followed the guidelines in our Contributing Documentation.
I have checked to ensure there aren't other open Pull Requests for the same update/change.
I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
I have written new tests for my resource or datasource changes & updated any relevent documentation.
I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
(For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

Compute - Fix failed Acc Test

This is a (please select all that apply):

Bug Fix
New Feature (ie adding a service, resource, or data source)
Enhancement
Breaking Change

Related Issue(s)

Fixes #0000

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

jackofallops

Hi @ms-zhenhua - Thanks for this PR. The tests touched here needed a little deeper investigation, so can you take a look at the comments below?

Thanks

jackofallops · 2024-09-23T13:34:01Z

internal/services/legacy/virtual_machine_managed_disks_resource_test.go

@@ -453,7 +453,7 @@ func TestAccVirtualMachine_ChangeAvailabilitySet(t *testing.T) {
 	data := acceptance.BuildTestData(t, "azurerm_virtual_machine", "test")
 	r := VirtualMachineResource{}

-	data.ResourceTest(t, r, []acceptance.TestStep{
+	data.ResourceTestIgnoreRecreate(t, r, []acceptance.TestStep{


This test doesn't actually test anything in the resource, rather it is testing Terraform's ForceNew action, so I think the test should actually be removed as it is providing no value to the resource.

jackofallops · 2024-09-23T13:44:10Z

internal/services/legacy/virtual_machine_scale_set_resource_test.go

@@ -185,7 +185,7 @@ func TestAccVirtualMachineScaleSet_verify_key_data_changed(t *testing.T) {
 	data := acceptance.BuildTestData(t, "azurerm_virtual_machine_scale_set", "test")
 	r := VirtualMachineScaleSetResource{}

-	data.ResourceTest(t, r, []acceptance.TestStep{
+	data.ResourceTestIgnoreRecreate(t, r, []acceptance.TestStep{


This test is also invalid. The schema is a set (since it has a max items of 1, it seems it should should be a list). Given this is a deprecated resource, and not receiving any fixes, I believe this test is safe to remove rather than paper over the problem.

jackofallops · 2024-09-23T13:53:59Z

internal/services/legacy/virtual_machine_scale_set_resource_test.go

+    match {
+      status_code = ["200-399"]
+    }


The test this relates to sometimes passes, do we know why this optional property is sometimes returned and sometimes not from the API?

I think this default value was recently added by Azure Team because other azurerm_application_gateway.probe related testcases like TestAccApplicationGateway_probesWithPort also failed due to this reason. However, this default value is consistent with the document .

jackofallops · 2024-09-23T14:01:46Z

internal/services/legacy/virtual_machine_unmanaged_disks_resource_test.go

@@ -282,7 +282,7 @@ func TestAccVirtualMachine_deleteVHDOptIn(t *testing.T) {
 func TestAccVirtualMachine_ChangeComputerName(t *testing.T) {
 	data := acceptance.BuildTestData(t, "azurerm_virtual_machine", "test")
 	r := VirtualMachineResource{}
-	data.ResourceTest(t, r, []acceptance.TestStep{
+	data.ResourceTestIgnoreRecreate(t, r, []acceptance.TestStep{


As above, this test just cycles a ForceNew property, and doesn't provide any resource value since Terraform will always just delete and recreate it. We should remove the test.

jackofallops · 2024-09-23T14:07:56Z

internal/services/legacy/virtual_machine_unmanaged_disks_resource_test.go

@@ -322,7 +322,7 @@ func TestAccVirtualMachine_changeOSDiskVhdUri(t *testing.T) {
 	data := acceptance.BuildTestData(t, "azurerm_virtual_machine", "test")
 	r := VirtualMachineResource{}

-	data.ResourceTest(t, r, []acceptance.TestStep{
+	data.ResourceTestIgnoreRecreate(t, r, []acceptance.TestStep{


Again here. This test doesn't provide any value to the resource functionality as it just triggers a ForceNew on the schema, which will always have the same outcome. This test should just be removed.

ms-zhenhua · 2024-09-24T04:01:49Z

Hi @jackofallops, thank you for your review. I have updated the PR. Could you please have another review?

katbyte

LGTM 🐙

github-actions · 2024-11-17T02:22:49Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

fix acc test

f9eef1a

github-actions bot added the size/XS label Sep 23, 2024

ms-zhenhua marked this pull request as ready for review September 23, 2024 09:13

jackofallops requested changes Sep 23, 2024

View reviewed changes

github-actions bot added the waiting-response label Sep 23, 2024

remove unnecessary testcases

1e38327

github-actions bot added size/XL and removed waiting-response size/XS labels Sep 24, 2024

ms-zhenhua requested a review from jackofallops September 24, 2024 04:01

rcskosir added enhancement service/virtual-machine service/vmss Virtual Machine Scale Sets labels Oct 14, 2024

katbyte approved these changes Oct 17, 2024

View reviewed changes

katbyte merged commit bbd9285 into hashicorp:main Oct 17, 2024
35 checks passed

github-actions bot added this to the v4.6.0 milestone Oct 17, 2024

github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`Compute` - Fix failed Acc Test #27465

`Compute` - Fix failed Acc Test #27465

ms-zhenhua commented Sep 23, 2024 •

edited

Loading

jackofallops left a comment

jackofallops Sep 23, 2024

ms-zhenhua Sep 24, 2024

jackofallops Sep 23, 2024

ms-zhenhua Sep 24, 2024

jackofallops Sep 23, 2024

ms-zhenhua Sep 24, 2024 •

edited

Loading

jackofallops Sep 23, 2024

ms-zhenhua Sep 24, 2024

jackofallops Sep 23, 2024

ms-zhenhua Sep 24, 2024

ms-zhenhua commented Sep 24, 2024

katbyte left a comment

github-actions bot commented Nov 17, 2024

Compute - Fix failed Acc Test #27465

Compute - Fix failed Acc Test #27465

Conversation

ms-zhenhua commented Sep 23, 2024 • edited Loading

Community Note

Description

PR Checklist

Changes to existing Resource / Data Source

Testing

Change Log

Related Issue(s)

jackofallops left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ms-zhenhua Sep 24, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ms-zhenhua commented Sep 24, 2024

katbyte left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 17, 2024

`Compute` - Fix failed Acc Test #27465

`Compute` - Fix failed Acc Test #27465

ms-zhenhua commented Sep 23, 2024 •

edited

Loading

ms-zhenhua Sep 24, 2024 •

edited

Loading