New resources: azurerm_ai_foundry azurerm_ai_foundry_project

[stephybun]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

• Updates the custom import function for azurerm_ai_services to only import cognitive accounts of type AIServices
• Fixes logic in the create for azurerm_ai_services around the customer managed key setting
• Adds the resource azurerm_ai_foundry
• Adds the resource azurerm_ai_foundry_project

Testing

Running...

The update test for the azurerm_ai_foundry_project is failing due to some odd behaviour on the parent azurerm_ai_foundry.

This issue on the Rest API spec explains the behaviour and should be fixed before we can merge this as it will cause a diff for users that try to update the project.

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_resource - support for the thing1 property [GH-00000]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Supersedes #26593
Supersedes #26844
Closes #25859
Closes #24454

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[katbyte]

LGTM 🍾

[deeikele]

@katbyte Please do not merge this PR, this doesn't look right to me.

@xuzhang3 It seems we're exposing hub and project kinds under the wrong resource provider (AI Services instead of AzureML). Is this intentional? AI Studio hub and projects are build on Azure ML RP and therefore should be introduced there.

[xuzhang3]

@katbyte Please do not merge this PR, this doesn't look right to me.

@xuzhang3 It seems we're exposing hub and project kinds under the wrong resource provider (AI Services instead of AzureML). Is this intentional? AI Studio hub and projects are build on Azure ML RP and therefore should be introduced there.

@katbyte @stephybun Can we changed this RP back to MLS instead of AI Services? @deeikele is the PM from azure machine learning team

[stephybun]

Hey @deeikele,

The naming is intentional to better reflect the commercial name of the resources. Even though these resources use the Machine Learning Services RP, they are marketed as AI Studio/Service resources in both the MSFT Learn Docs, as well as in the portal.

It's customary in the provider to try and use the brand name for resources where possible, since it's likely that a large majority of users would be using the MSFT docs and tutorials to navigate their way through the Azure ecosystem instead of checking the underlying RP in the API specs for the resources that they are wanting to provision. That is the reason for logically grouping these AI resources under the new service package aiservices instead of machinelearning or cognitive. Admittedly the resource names would also benefit from a bit of tweaking here e.g. azurerm_ai_services_hub -> azurerm_ai_hub.

We're not privy to any MSFT internal roadmaps so we can only ever go by what is made public. If you have some insight into the future of these resources we can certainly reassess the naming.

[deeikele]

This naming is not correct, since the naming is to a different resource provider than what is actually specified in Bicep/ARM/REST API service names. Also in correspondence to RBAC, the service name would be Azure ML in the current product setup. Can we please sync on future roadmap so we can make a joint decision on what resonates best with our joint customer groups?

…

________________________________ From: stephybun ***@***.***> Sent: Monday, 23 September 2024 00:49 To: hashicorp/terraform-provider-azurerm ***@***.***> Cc: Dennis Eikelenboom ***@***.***>; Mention ***@***.***> Subject: Re: [hashicorp/terraform-provider-azurerm] `AI Services` - adding Hub and Project resources (PR #27424) Hey @deeikele<https://github.com/deeikele>, The naming is intentional to better reflect the commercial name of the resources. Even though these resources use the Machine Learning Services RP, they are marketed as AI Studio/Service resources in both the MSFT Learn Docs<https://learn.microsoft.com/en-us/azure/ai-studio/concepts/architecture>, as well as in the portal. It's customary in the provider to try and use the brand name for resources where possible, since it's likely that a large majority of users would be using the MSFT docs and tutorials to navigate their way through the Azure ecosystem instead of checking the underlying RP in the API specs for the resources that they are wanting to provision. That is the reason for logically grouping these AI resources under the new service package aiservices instead of machinelearning or cognitive. Admittedly the resource names would also benefit from a bit of tweaking here e.g. azurerm_ai_services_hub -> azurerm_ai_hub. We're not privy to any MSFT internal roadmaps so we can only ever go by what is made public. If you have some insight into the future of these resources we can certainly reassess the naming. — Reply to this email directly, view it on GitHub<#27424 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AWA3RMOEQST6SBLXE2H3ZKDZX7BXHAVCNFSM6AAAAABONS7SUGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRXGQ3DAMZTGY>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[Lachlan-White]

👀

[xuzhang3]

Any updates on the concerns @deeikele mentioned?

[dvasdekis]

Chiming in as a customer, I know that this uses some variant of the old ML Workspace APIs under the hood, but I expected this resource type to appear as a new 'AI Services' category in the list of resource types, rather than under ML Workspace, because the interface is completely different, the Azure documentation is on different pages(here vs here), and it does different stuff.

[ReneeErnst]

My team is eagerly awaiting this addition to this provider - any estimate as to when it might be available?

[stephybun]

@hashicorp/terraform-azure this is waiting on the feedback from the service team/PM about Azure/azure-rest-api-specs#31696 before this can be merged.