Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bastionhosts - upgrade api version from 2023-11-01 to 2024-01-01 #27277

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

T0biii
Copy link
Contributor

@T0biii T0biii commented Sep 4, 2024

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

We want to use Bastion Premium and session recording and this feature only exists in API version 2024-01-01. So we have to upgrade API version to 2024-01-01.

I will create a separate PR for Bastion Premium and Session Recording feature

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevent documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

did only bump API Version (currently have no test subscription)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • bastionhosts - upgrade api version from 2023-11-01 to 2024-01-01

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Support for Azure Bastion Premium SKU #27013

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

@T0biii T0biii changed the title Bastion - upgrade api version from 2023-11-01 to 2024-01-01 bastionhosts - upgrade api version from 2023-11-01 to 2024-01-01 Sep 4, 2024
@T0biii T0biii force-pushed the update-bastion-api-version branch from 1e84b7a to c6d5097 Compare September 5, 2024 06:06
@T0biii T0biii force-pushed the update-bastion-api-version branch from c6d5097 to aaa635a Compare September 5, 2024 06:08
@T0biii T0biii force-pushed the update-bastion-api-version branch from aaa635a to 1351448 Compare September 5, 2024 06:11
@T0biii T0biii force-pushed the update-bastion-api-version branch from 1351448 to 7fa11d0 Compare September 5, 2024 06:12
@T0biii T0biii force-pushed the update-bastion-api-version branch from 7fa11d0 to 90e3db8 Compare September 5, 2024 06:15
@T0biii T0biii force-pushed the update-bastion-api-version branch from 90e3db8 to f10e371 Compare September 5, 2024 06:30
@T0biii T0biii force-pushed the update-bastion-api-version branch from f10e371 to 1643702 Compare September 5, 2024 07:02
@github-actions github-actions bot added size/XS and removed size/XL labels Sep 5, 2024
@T0biii T0biii changed the title network - upgrade api version from 2023-11-01 to 2024-01-01 bastionhosts - upgrade api version from 2023-11-01 to 2024-01-01 Sep 5, 2024
@T0biii T0biii marked this pull request as draft September 5, 2024 07:19
@T0biii T0biii force-pushed the update-bastion-api-version branch from 45abed6 to e1531ab Compare September 5, 2024 07:23
@T0biii
Copy link
Contributor Author

T0biii commented Sep 5, 2024

seems like the whole network part needs to be updated? Unfortunately I lack experience here how to update the API for all.
If someone could support me here I would be happy

only updating the bastionhosts api semms to pass now the ci

@T0biii T0biii force-pushed the update-bastion-api-version branch from 31e94ae to c34bcdd Compare September 5, 2024 10:25
@T0biii T0biii marked this pull request as ready for review September 5, 2024 10:35
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbfrahry mbfrahry merged commit e979da3 into hashicorp:main Sep 6, 2024
30 checks passed
@mbfrahry mbfrahry added this to the v4.2.0 milestone Sep 6, 2024
mbfrahry added a commit that referenced this pull request Sep 6, 2024
Copy link

github-actions bot commented Oct 7, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants