-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ed25519 ssh key support for compute and storage account local user #27202
Conversation
So compute's ssh validation can be refactored
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR!
I've taken a look through and left some comments inline, but this is mostly looking good to me 👍
internal/services/storage/storage_account_local_user_resource.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gerrytan LGTM!
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Community Note
Description
Adds support for ed25519 ssh key for compute resource (already supported in az cli) and storage account local user resource.
PR Checklist
For example: “
resource_name_here
- description of change e.g. adding propertynew_property_name_here
”Changes to existing Resource / Data Source
Testing
make acctests SERVICE='compute' TESTARGS='-run=TestAccLinuxVirtualMachine_auth' TESTTIMEOUT='120m'
- output log ✅make acctests SERVICE='compute' TESTARGS='-run=TestAccOrchestratedVirtualMachineScaleSet_' TESTTIMEOUT='120m'
- output log ✅ (there are race condition errors on resource cleanup but unrelated to this change)make acctests SERVICE='storage' TESTARGS='-run=TestAccLocalUser_' TESTTIMEOUT='120m'
- output log ✅Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_linux_virtual_machine
,azurerm_storage_account_local_user
- adds support for ed25519 ssh key [provider does not support ed25519 ssh keys while azure does. #26587]This is a (please select all that apply):
Related Issue(s)
#26587
Note
If this PR changes meaningfully during the course of review please update the title and description as required.