New resource: azurerm_netapp_backup_vault and azurerm_netapp_backup_policy

examples/netapp/nfsv3_volume_with_backup_policy/README.md

@@ -0,0 +1,5 @@
+## Example: Azure NetApp Files Volume with Backup Policy enabled
+
+This example shows how to create an Azure NetApp volume with Backup policy enabled.
+
+For more information, please refer to [Understand Azure NetApp Files backup](https://learn.microsoft.com/en-us/azure/azure-netapp-files/backup-introduction).

examples/netapp/nfsv3_volume_with_backup_policy/main.tf

@@ -0,0 +1,100 @@
+provider "azurerm" {
+  features {
+    netapp {
+      prevent_volume_destruction = false
+      delete_backups_on_backup_vault_destroy = true
+	  }
+  }
+}
+
+resource "azurerm_resource_group" "example" {
+  name     = "${var.prefix}-resources"
+  location = var.location
+}
+
+resource "azurerm_virtual_network" "example" {
+  name                = "${var.prefix}-virtualnetwork"
+  location            = azurerm_resource_group.example.location
+  resource_group_name = azurerm_resource_group.example.name
+  address_space       = ["10.0.0.0/16"]
+}
+
+resource "azurerm_subnet" "example" {
+  name                 = "${var.prefix}-subnet"
+  resource_group_name  = azurerm_resource_group.example.name
+  virtual_network_name = azurerm_virtual_network.example.name
+  address_prefixes     = ["10.0.2.0/24"]
+
+  delegation {
+    name = "testdelegation"
+
+    service_delegation {
+      name    = "Microsoft.Netapp/volumes"
+      actions = ["Microsoft.Network/networkinterfaces/*", "Microsoft.Network/virtualNetworks/subnets/join/action"]
+    }
+  }
+}
+
+resource "azurerm_netapp_account" "example" {
+  name                = "${var.prefix}-netappaccount"
+  location            = azurerm_resource_group.example.location
+  resource_group_name = azurerm_resource_group.example.name
+}
+
+resource "azurerm_netapp_backup_vault" "example" {
+  name                = "${var.prefix}-netappbackupvault"
+  resource_group_name = azurerm_resource_group.example.name
+  location            = azurerm_resource_group.example.location
+  account_name        = azurerm_netapp_account.example.name
+}
+
+resource "azurerm_netapp_backup_policy" "example" {
+  name                    = "${var.prefix}-netappbackuppolicy"
+  resource_group_name     = azurerm_resource_group.example.name
+  location                = azurerm_resource_group.example.location
+  account_name            = azurerm_netapp_account.example.name
+  daily_backups_to_keep   = 2
+  weekly_backups_to_keep  = 2
+  monthly_backups_to_keep = 2
+  enabled = true
+}
+
+resource "azurerm_netapp_pool" "example" {
+  name                = "${var.prefix}-netapppool"
+  location            = azurerm_resource_group.example.location
+  resource_group_name = azurerm_resource_group.example.name
+  account_name        = azurerm_netapp_account.example.name
+  service_level       = "Standard"
+  size_in_tb          = 4
+}
+
+resource "azurerm_netapp_volume" "example" {
+  lifecycle {
+    prevent_destroy = true
+  }
+
+  name                = "${var.prefix}-netappvolume"
+  location            = azurerm_resource_group.example.location
+  resource_group_name = azurerm_resource_group.example.name
+  account_name        = azurerm_netapp_account.example.name
+  pool_name           = azurerm_netapp_pool.example.name
+  volume_path         = "${var.prefix}-netappvolume"
+  service_level       = "Standard"
+  protocols           = ["NFSv3"]
+  network_features    = "Basic"
+  subnet_id           = azurerm_subnet.example.id
+  storage_quota_in_gb = 100
+
+  data_protection_backup_policy {
+    backup_vault_id  = azurerm_netapp_backup_vault.example.id
+    backup_policy_id = azurerm_netapp_backup_policy.example.id
+    policy_enabled   = true
+  }
+
+  export_policy_rule {
+    rule_index = 1
+    allowed_clients = ["0.0.0.0/0"]
+    protocols_enabled = ["NFSv3"]
+    unix_read_write = true
+  }
+}

examples/netapp/nfsv3_volume_with_backup_policy/variables.tf

@@ -0,0 +1,7 @@
+variable "location" {
+  description = "The Azure location where all resources in this example should be created."
+}
+
+variable "prefix" {
+  description = "The prefix used for all resources used by this example"
+}

internal/features/defaults.go

@@ -78,5 +78,9 @@ func Default() UserFeatures {
 			VMBackupStopProtectionAndRetainDataOnDestroy: false,
 			PurgeProtectedItemsFromVaultOnDestroy:        false,
 		},
+		NetApp: NetAppFeatures{
+			DeleteBackupsOnBackupVaultDestroy: false,
+			PreventVolumeDestruction:          true,
+		},
 	}
 }

internal/features/user_flags.go

@@ -21,6 +21,7 @@ type UserFeatures struct {
 	PostgresqlFlexibleServer PostgresqlFlexibleServerFeatures
 	MachineLearning          MachineLearningFeatures
 	RecoveryService          RecoveryServiceFeatures
+	NetApp                   NetAppFeatures
 }
 
 type CognitiveAccountFeatures struct {
@@ -109,3 +110,8 @@ type RecoveryServiceFeatures struct {
 	VMBackupStopProtectionAndRetainDataOnDestroy bool
 	PurgeProtectedItemsFromVaultOnDestroy        bool
 }
+
+type NetAppFeatures struct {
+	DeleteBackupsOnBackupVaultDestroy bool
+	PreventVolumeDestruction          bool
+}

internal/provider/features.go

@@ -387,6 +387,28 @@ func schemaFeatures(supportLegacyTestSuite bool) *pluginsdk.Schema {
 				},
 			},
 		},
+
+		"netapp": {
+			Type:     pluginsdk.TypeList,
+			Optional: true,
+			MaxItems: 1,
+			Elem: &pluginsdk.Resource{
+				Schema: map[string]*pluginsdk.Schema{
+					"delete_backups_on_backup_vault_destroy": {
+						Description: "When enabled, backups will be deleted when the `azurerm_netapp_backup_vault` resource is destroyed",
+						Type:        pluginsdk.TypeBool,
+						Optional:    true,
+						Default:     false,
+					},
+					"prevent_volume_destruction": {
+						Description: "When enabled, the volume will not be destroyed, safeguarding from severe data loss",
+						Type:        pluginsdk.TypeBool,
+						Optional:    true,
+						Default:     true,
+					},
+				},
+			},
+		},
 	}
 
 	// this is a temporary hack to enable us to gradually add provider blocks to test configurations
@@ -648,5 +670,18 @@ func expandFeatures(input []interface{}) features.UserFeatures {
 		}
 	}
 
+	if raw, ok := val["netapp"]; ok {
+		items := raw.([]interface{})
+		if len(items) > 0 {
+			netappRaw := items[0].(map[string]interface{})
+			if v, ok := netappRaw["delete_backups_on_backup_vault_destroy"]; ok {
+				featuresMap.NetApp.DeleteBackupsOnBackupVaultDestroy = v.(bool)
+			}
+			if v, ok := netappRaw["prevent_volume_destruction"]; ok {
+				featuresMap.NetApp.PreventVolumeDestruction = v.(bool)
+			}
+		}
+	}
+
 	return featuresMap
 }

internal/provider/features_test.go

@@ -91,6 +91,10 @@ func TestExpandFeatures(t *testing.T) {
 					VMBackupStopProtectionAndRetainDataOnDestroy: false,
 					PurgeProtectedItemsFromVaultOnDestroy:        false,
 				},
+				NetApp: features.NetAppFeatures{
+					DeleteBackupsOnBackupVaultDestroy: false,
+					PreventVolumeDestruction:          true,
+				},
 			},
 		},
 		{
@@ -201,6 +205,12 @@ func TestExpandFeatures(t *testing.T) {
 							"purge_protected_items_from_vault_on_destroy":          true,
 						},
 					},
+					"netapp": []interface{}{
+						map[string]interface{}{
+							"delete_backups_on_backup_vault_destroy": true,
+							"prevent_volume_destruction":             true,
+						},
+					},
 				},
 			},
 			Expected: features.UserFeatures{
@@ -274,6 +284,10 @@ func TestExpandFeatures(t *testing.T) {
 					VMBackupStopProtectionAndRetainDataOnDestroy: true,
 					PurgeProtectedItemsFromVaultOnDestroy:        true,
 				},
+				NetApp: features.NetAppFeatures{
+					DeleteBackupsOnBackupVaultDestroy: true,
+					PreventVolumeDestruction:          true,
+				},
 			},
 		},
 		{
@@ -384,6 +398,12 @@ func TestExpandFeatures(t *testing.T) {
 							"purge_protected_items_from_vault_on_destroy":          false,
 						},
 					},
+					"netapp": []interface{}{
+						map[string]interface{}{
+							"delete_backups_on_backup_vault_destroy": false,
+							"prevent_volume_destruction":             false,
+						},
+					},
 				},
 			},
 			Expected: features.UserFeatures{
@@ -457,6 +477,10 @@ func TestExpandFeatures(t *testing.T) {
 					VMBackupStopProtectionAndRetainDataOnDestroy: false,
 					PurgeProtectedItemsFromVaultOnDestroy:        false,
 				},
+				NetApp: features.NetAppFeatures{
+					DeleteBackupsOnBackupVaultDestroy: false,
+					PreventVolumeDestruction:          false,
+				},
 			},
 		},
 	}
@@ -1745,3 +1769,92 @@ func TestExpandFeaturesRecoveryService(t *testing.T) {
 		}
 	}
 }
+
+func TestExpandFeaturesNetApp(t *testing.T) {
+	testData := []struct {
+		Name     string
+		Input    []interface{}
+		EnvVars  map[string]interface{}
+		Expected features.UserFeatures
+	}{
+		{
+			Name: "Empty Block",
+			Input: []interface{}{
+				map[string]interface{}{
+					"netapp": []interface{}{},
+				},
+			},
+			Expected: features.UserFeatures{
+				NetApp: features.NetAppFeatures{
+					DeleteBackupsOnBackupVaultDestroy: false,
+					PreventVolumeDestruction:          true,
+				},
+			},
+		},
+		{
+			Name: "NetApp Features Enabled",
+			Input: []interface{}{
+				map[string]interface{}{
+					"netapp": []interface{}{
+						map[string]interface{}{
+							"delete_backups_on_backup_vault_destroy": true,
+							"prevent_volume_destruction":             true,
+						},
+					},
+				},
+			},
+			Expected: features.UserFeatures{
+				NetApp: features.NetAppFeatures{
+					DeleteBackupsOnBackupVaultDestroy: false,
+					PreventVolumeDestruction:          true,
+				},
+			},
+		},
+		{
+			Name: "NetApp Features Disabled",
+			Input: []interface{}{
+				map[string]interface{}{
+					"netapp": []interface{}{
+						map[string]interface{}{
+							"delete_backups_on_backup_vault_destroy": false,
+							"prevent_volume_destruction":             false,
+						},
+					},
+				},
+			},
+			Expected: features.UserFeatures{
+				NetApp: features.NetAppFeatures{
+					DeleteBackupsOnBackupVaultDestroy: false,
+					PreventVolumeDestruction:          false,
+				},
+			},
+		},
+		{
+			Name: "NetApp Features Reverse Default Values",
+			Input: []interface{}{
+				map[string]interface{}{
+					"netapp": []interface{}{
+						map[string]interface{}{
+							"delete_backups_on_backup_vault_destroy": true,
+							"prevent_volume_destruction":             false,
+						},
+					},
+				},
+			},
+			Expected: features.UserFeatures{
+				NetApp: features.NetAppFeatures{
+					DeleteBackupsOnBackupVaultDestroy: true,
+					PreventVolumeDestruction:          false,
+				},
+			},
+		},
+	}
+
+	for _, testCase := range testData {
+		t.Logf("[DEBUG] Test Case: %q", testCase.Name)
+		result := expandFeatures(testCase.Input)
+		if !reflect.DeepEqual(result.Subscription, testCase.Expected.Subscription) {
+			t.Fatalf("Expected %+v but got %+v", result.Subscription, testCase.Expected.Subscription)
+		}
+	}
+}

internal/provider/framework/config.go

@@ -481,6 +481,29 @@ func (p *ProviderConfig) Load(ctx context.Context, data *ProviderModel, tfVersio
 			f.RecoveryService.VMBackupStopProtectionAndRetainDataOnDestroy = false
 			f.RecoveryService.PurgeProtectedItemsFromVaultOnDestroy = false
 		}
+
+		if !features.NetApp.IsNull() && !features.NetApp.IsUnknown() {
+			var feature []NetApp
+			d := features.NetApp.ElementsAs(ctx, &feature, true)
+			diags.Append(d...)
+			if diags.HasError() {
+				return
+			}
+
+			f.NetApp.DeleteBackupsOnBackupVaultDestroy = false
+			if !feature[0].DeleteBackupsOnBackupVaultDestroy.IsNull() && !feature[0].DeleteBackupsOnBackupVaultDestroy.IsUnknown() {
+				f.NetApp.DeleteBackupsOnBackupVaultDestroy = feature[0].DeleteBackupsOnBackupVaultDestroy.ValueBool()
+			}
+
+			f.NetApp.PreventVolumeDestruction = true
+			if !feature[0].PreventVolumeDestruction.IsNull() && !feature[0].PreventVolumeDestruction.IsUnknown() {
+				f.NetApp.PreventVolumeDestruction = feature[0].PreventVolumeDestruction.ValueBool()
+			}
+
+		} else {
+			f.NetApp.DeleteBackupsOnBackupVaultDestroy = false
+			f.NetApp.PreventVolumeDestruction = true
+		}
 	}
 
 	p.clientBuilder.Features = f