Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_web_application_firewall_policy - update tests using managed_rules.managed_rule_set.version 3.1 -> 3.2 #26913

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

mbfrahry
Copy link
Member

@mbfrahry mbfrahry commented Aug 1, 2024

This PR fixes tests using managed_rules.managed_rule_set.version 3.1 which does not support request_body_inspect_limit_in_kb causing issues like

              ~ policy_settings {
                  ~ request_body_inspect_limit_in_kb = 0 -> 128
                    # (5 unchanged attributes hidden)
                }

This PR updates all tests using 3.1 to 3.2

Copy link
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbfrahry mbfrahry added this to the v3.115.0 milestone Aug 2, 2024
@mbfrahry mbfrahry merged commit f988645 into main Aug 2, 2024
30 checks passed
@mbfrahry mbfrahry deleted the azurerm_web_application_firewall_policy-3.1 branch August 2, 2024 17:32
Copy link

github-actions bot commented Sep 3, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants