Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_kubernetes_cluster - fix panic in service_mesh_profile in 4.0 mode #26783

Merged
merged 4 commits into from
Jul 25, 2024
Merged

azurerm_kubernetes_cluster - fix panic in service_mesh_profile in 4.0 mode #26783

merged 4 commits into from
Jul 25, 2024

Conversation

stephybun
Copy link
Member

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

jackofallops
jackofallops approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stephybun - LGTM 🐿️

@stephybun stephybun merged commit 4b29491 into main Jul 25, 2024
30 checks passed
@stephybun stephybun deleted the b/fix-panic-service-mesh-profile branch July 25, 2024 13:54
@github-actions github-actions bot added this to the v3.114.0 milestone Jul 25, 2024
lonegunmanb pushed a commit to lonegunmanb/terraform-provider-azurerm that referenced this pull request Aug 5, 2024
@stephybun @lonegunmanb
azurerm_kubernetes_cluster - fix panic in service_mesh_profile in…
debf240 
… 4.0 mode (hashicorp#26783)

* fix panic in aks data source

* remove Mariner sku

* remove a redundant test and fix condition for skipping tests not applicable in 4.0

* remove test step that no longer applies in 4.0
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jackofallops jackofallops jackofallops approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
v3.114.0
Development

Successfully merging this pull request may close these issues.
2 participants
@stephybun @jackofallops