[New Resource] - azurerm_postgresql_flexible_server_virtual_endpoint

[bruceharrison1984]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

This adds support to Flexible Postgres Servers for creating Virtual Endpoints.

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_postgresql_flexible_server_virtual_endpoint - New Resource added [Support for virtual endpoints for Postgres Flexible Servers #25803]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #25803

[stephybun]

We try to be as explicit as possible in the test configurations and don't pass updated ID values in as arguments to the config. This also fails at the moment:

------- Stdout: -------
=== RUN   TestAccPostgresqlFlexibleServerVirtualEndpoint_update
=== PAUSE TestAccPostgresqlFlexibleServerVirtualEndpoint_update
=== CONT  TestAccPostgresqlFlexibleServerVirtualEndpoint_update
    testcase.go:121: Step 1/4 error: Error running pre-apply plan: exit status 1
        Error: length should be equal to or less than 63, got "acctest-psql-virtualendpoint-primary-240807125523377850-replica-0"
          with azurerm_postgresql_flexible_server.test_replica_0,
          on terraform_plugin_test.tf line 51, in resource "azurerm_postgresql_flexible_server" "test_replica_0":
          51:   name                          = "${azurerm_postgresql_flexible_server.test.name}-replica-0"
--- FAIL: TestAccPostgresqlFlexibleServerVirtualEndpoint_update (15.02s)
FAIL

[bruceharrison1984]

That's interesting, it was passing locally. Easy enough to shorten the name though.

Would you recommend passing in the full virtual endpoint resources rather than just the ID? Can you point me towards something more in line with what you're looking for?

[stephybun]

I'm not sure I'll be able to find an example quickly for this specific case, but typically update tests will take advantage of an already existing basic or complete config, so the acceptance test would like:

func TestAccPostgresqlFlexibleServerVirtualEndpoint_update(t *testing.T) {
	data := acceptance.BuildTestData(t, "azurerm_postgresql_flexible_server_virtual_endpoint", "test")
	r := PostgresqlFlexibleServerVirtualEndpointResource{}

	data.ResourceTest(t, r, []acceptance.TestStep{
		{
			Config: r.basic(data),
			Check: acceptance.ComposeTestCheckFunc(
				check.That(data.ResourceName).ExistsInAzure(r),
			),
		},
		data.ImportStep(),
		{
			Config: r.update(data),
			Check: acceptance.ComposeTestCheckFunc(
				check.That(data.ResourceName).ExistsInAzure(r),
			),
		},
		data.ImportStep(),
	})
}

But on second though it's probably sufficient to just shorten the name to prevent the error.

[bruceharrison1984]

I decreased the length of resource names, and the tests all passed on the TC server

[stephybun]

Thanks @bruceharrison1984 LGTM 👍

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.