New Resource: azurerm_communication_service_email_domain_association

[jkroepke]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Follow-Up from: #26179 (comment)

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevent documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

=== RUN   TestAccCommunicationServiceEmailDomainAssociationResource_basic
=== PAUSE TestAccCommunicationServiceEmailDomainAssociationResource_basic
=== CONT  TestAccCommunicationServiceEmailDomainAssociationResource_basic
=== RUN   TestAccCommunicationServiceEmailDomainAssociationResource_requiresImport
=== PAUSE TestAccCommunicationServiceEmailDomainAssociationResource_requiresImport
=== CONT  TestAccCommunicationServiceEmailDomainAssociationResource_requiresImport
=== RUN   TestAccCommunicationServiceEmailDomainAssociationResource_deleted
=== PAUSE TestAccCommunicationServiceEmailDomainAssociationResource_deleted
=== CONT  TestAccCommunicationServiceEmailDomainAssociationResource_deleted
--- PASS: TestAccCommunicationServiceEmailDomainAssociationResource_deleted (388.22s)
--- PASS: TestAccCommunicationServiceEmailDomainAssociationResource_requiresImport (396.21s)
--- PASS: TestAccCommunicationServiceEmailDomainAssociationResource_basic (398.58s)
PASS

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• New Resource: azurerm_communication_service_email_domain_association [GH-00000]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #22995

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[dkalmin]

Hello @katbyte! I stumbled across this PR from @jkroepke looking for this exact implementation. I was wondering if there is an estimated date this will be GTM?We are currently in the process of implementing ACS using terraform.

[jkroepke]

@jackofallops Kindly requesting an review here.

[jackofallops]

Thanks @jkroepke - I've left some comments and changes below if you can take a look, I'll continue review and get tests run once they're addressed.

Thanks!

[jkroepke]

I apply all suggestions, tests are green on my system.

[jackofallops]

Hi @jkroepke - Thanks for the quick turnaround on those changes, just a couple more that I think I missed last pass. Once they're done I can get the tests run on the CI and we should be good to merge.

Thanks again!

[jackofallops]

We can only be sure of having the resource ID at this point, so we should not need to do this, and work exclusively with the ID (and the data it contains) for delete operations. It's also unused in the rest of the function here too.

Suggested change

	var model EmailDomainAssociationResourceModel
	if err := metadata.Decode(&model); err != nil {
	return err
	}

[jackofallops]

Thanks for the changes @jkroepke - This LGTM now 👍

[jackofallops]

Tests passing:

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.