Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_virtual_desktop_host_pool - remove ForceNew from preferred_app_group_type #26333

Merged
merged 1 commit into from
Jun 14, 2024
Merged

azurerm_virtual_desktop_host_pool - remove ForceNew from preferred_app_group_type #26333

merged 1 commit into from
Jun 14, 2024

Conversation

sinbai
Copy link
Contributor

@sinbai sinbai commented Jun 14, 2024

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

After validating the behavior of the API, the preferred_app_group_type is allowed to be updated. Submit this PR to remove the ForceNew for preferred_app_group_type to fix #26324 .

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevent documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

PASS: TestAccVirtualDesktopHostPool_update (283.88s)

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #26324

@sinbai sinbai mentioned this pull request Jun 14, 2024
Closed
1 task
mbfrahry
mbfrahry approved these changes Jun 14, 2024
View reviewed changes
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mbfrahry mbfrahry merged commit 2823c43 into hashicorp:main Jun 14, 2024
33 checks passed
@mbfrahry mbfrahry added this to the v3.109.0 milestone Jun 14, 2024
mbfrahry added a commit that referenced this pull request Jun 14, 2024
@mbfrahry
Update CHANGELOG.md for #26333
c03da45
dduportal pushed a commit to jenkins-infra/azure that referenced this pull request Jun 21, 2024
@jenkins-infra-updatecli @jenkins-infra-bot
Bump Terraform azurerm provider version to 3.109.0 (#739)
42f405d 
<Actions>
<action
id="f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8">
        <h3>Bump Terraform `azurerm` provider version</h3>
<details
id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24">
            <summary>Update Terraform lock file</summary>
<p>changes detected:&#xA;&#x9;&#34;hashicorp/azurerm&#34; updated from
&#34;3.108.0&#34; to &#34;3.109.0&#34; in file
&#34;.terraform.lock.hcl&#34;</p>
            <details>
                <summary>3.109.0</summary>
<pre>Changelog retrieved
from:&#xA;&#x9;https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.109.0&#xA;FEATURES:&#xA;&#xA;*
**New Data Source:** `azurerm_automation_runbook`
([#26359](hashicorp/terraform-provider-azurerm#26359
**New Resource:**
`azurerm_data_protection_backup_instance_postgresql_flexible_server`
([#26249](hashicorp/terraform-provider-azurerm#26249
**New Resource:** `azurerm_email_communication_service_domain`
([#26179](hashicorp/terraform-provider-azurerm#26179
**New Resource:** `azurerm_system_center_virtual_machine_manager_cloud`
([#25429](hashicorp/terraform-provider-azurerm#25429
**New Resource:**
`azurerm_system_center_virtual_machine_manager_virtual_machine_template`
([#25449](hashicorp/terraform-provider-azurerm#25449
**New Resource:**
`azurerm_system_center_virtual_machine_manager_virtual_network`
([#25451](https://github.com/hashicorp/terraform-provider-azurerm/issues/25451))&#xA;&#xA;ENHANCEMENTS:&#xA;&#xA;*
Data Source: `azurerm_hdinsight_cluster` - export the `cluster_id`
attribute
([#26228](hashicorp/terraform-provider-azurerm#26228
`azurerm_cosmosdb_sql_container` - support for the `partition_key_kind`
and `partition_key_paths` properties
([#26372](hashicorp/terraform-provider-azurerm#26372
`azurerm_data_protection_backup_instance_blob_storage` - support for the
`storage_account_container_names` property
([#26232](hashicorp/terraform-provider-azurerm#26232
`azurerm_virtual_network_peering` - support for the
`peer_complete_virtual_networks_enabled`, `only_ipv6_peering_enabled`,
`local_subnet_names`, and `remote_subnet_names` properties
([#26229](hashicorp/terraform-provider-azurerm#26229
`azurerm_virtual_desktop_host_pool` - changing the
`preferred_app_group_type` property no longer creates a new resource
([#26333](hashicorp/terraform-provider-azurerm#26333
`azurerm_maps_account` - support for the `location`, `identity`, `cors`
and `data_store` properties
([#26397](https://github.com/hashicorp/terraform-provider-azurerm/issues/26397))&#xA;&#xA;BUG
FIXES:&#xA;&#xA;* `azurerm_automation_job_schedule` - updates
`azurerm_automation_job_schedule` to use a composite resource id and
allows `azurerm_automation_runbook` to be updated without causing
`azurerm_automation_job_schedule` to recreate
([#22164](hashicorp/terraform-provider-azurerm#22164
`azurerm_databricks_workspace`- correctly allow disabling the default
firewall
([#26339](hashicorp/terraform-provider-azurerm#26339
`azurerm_virtual_hub_*` - spliting create and update so lifecycle ignore
changes works correctly
([#26310](https://github.com/hashicorp/terraform-provider-azurerm/issues/26310))&#xA;&#xA;DEPRECATIONS:&#xA;&#xA;*
Data Source: `azurerm_mariadb_server` - deprecated since the service is
retiring. Please use `azurerm_mysql_flexible_server` instead
([#26354](hashicorp/terraform-provider-azurerm#26354
`azurerm_mariadb_configuration` - deprecated since the service is
retiring. Please use `azurerm_mysql_flexible_server_configuration`
instead
([#26354](hashicorp/terraform-provider-azurerm#26354
`azurerm_mariadb_database` - deprecated since the service is retiring.
Please use `azurerm_mysql_flexible_database` instead
([#26354](hashicorp/terraform-provider-azurerm#26354
`azurerm_mariadb_firewall_rule` - deprecated since the service is
retiring. Please use `azurerm_mysql_flexible_server_firewall_rule`
instead
([#26354](hashicorp/terraform-provider-azurerm#26354
`azurerm_mariadb_server` - deprecated since the service is retiring.
Please use `azurerm_mysql_flexible_server` instead
([#26354](hashicorp/terraform-provider-azurerm#26354
`azurerm_mariadb_virtual_network_rule` - deprecated since the service is
retiring
([#26354](https://github.com/hashicorp/terraform-provider-azurerm/issues/26354))&#xA;&#xA;&#xA;</pre>
            </details>
        </details>
<a
href="https://infra.ci.jenkins.io/job/updatecli/job/azure/job/main/256/">Jenkins
pipeline link</a>
    </action>
</Actions>

---

<table>
  <tr>
    <td width="77">
<img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli
logo" width="50" height="50">
    </td>
    <td>
      <p>
Created automatically by <a
href="https://www.updatecli.io/">Updatecli</a>
      </p>
      <details><summary>Options:</summary>
        <br />
<p>Most of Updatecli configuration is done via <a
href="https://www.updatecli.io/docs/prologue/quick-start/">its
manifest(s)</a>.</p>
        <ul>
<li>If you close this pull request, Updatecli will automatically reopen
it, the next time it runs.</li>
<li>If you close this pull request and delete the base branch, Updatecli
will automatically recreate it, erasing all previous commits made.</li>
        </ul>
        <p>
Feel free to report any issues at <a
href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br
/>
If you find this tool useful, do not hesitate to star <a
href="https://github.com/updatecli/updatecli/stargazers">our GitHub
repository</a> as a sign of appreciation, and/or to tell us directly on
our <a
href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>!
        </p>
      </details>
    </td>
  </tr>
</table>

Co-authored-by: Jenkins Infra Bot (updatecli) <[email protected]>
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mbfrahry mbfrahry mbfrahry approved these changes

Assignees
No one assigned
Labels
documentation service/virtual-desktops size/XS
Projects
None yet
Milestone
v3.109.0
Development

Successfully merging this pull request may close these issues.

Azure Host Pool preferred_app_group_type change forces replace
2 participants
@sinbai @mbfrahry