`azurerm_network_interface` - removes `Computed` from `dns_server` and renames `enable_` to `_enabled` #26293

stephybun · 2024-06-11T08:40:06Z

Community Note

Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Removed Computed from dns_servers
Renamed enable_ip_forwarding to ip_forwarding_enabled
Renamed enable_accelerated_networking to accelerated_networking_enabled
Updated the update function to patch the existing resource model instead of populating a new model

Testing

This is a (please select all that apply):

Bug Fix
New Feature (ie adding a service, resource, or data source)
Enhancement
Breaking Change

Related Issue(s)

Fixes #21225

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

…bled

…n update

mbfrahry

LGTM with just a minor comment on adding Deprecated messages to the fields we are removing from the datasource

mbfrahry · 2024-06-11T21:27:06Z

internal/services/network/network_interface_data_source.go

+	if !features.FourPointOhBeta() {
+		dataSource.Schema["enable_ip_forwarding"] = &pluginsdk.Schema{
+			Type:     pluginsdk.TypeBool,
+			Computed: true,


Do we want to add a Deprecated messages to this attribute?

mbfrahry · 2024-06-11T21:27:24Z

internal/services/network/network_interface_data_source.go

+			Type:     pluginsdk.TypeBool,
+			Computed: true,
+		}
+		dataSource.Schema["enable_accelerated_networking"] = &pluginsdk.Schema{


And do we want to add a Deprecated messages to this attribute?

mbfrahry · 2024-06-11T21:40:56Z

There are also a number of tests that are using these Deprecated attributes? Should we go through those now and remove them in favor of the new attributes?

stephybun · 2024-06-12T06:07:52Z

Thanks @mbfrahry, replaced the deprecated properties with the new ones in the the test configs where I could.

…with azurerm 4.0 hashicorp/terraform-provider-azurerm#26293

<Actions> <action id="f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8"> <h3>Bump Terraform `azurerm` provider version</h3> <details id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24"> <summary>Update Terraform lock file</summary> <p>changes detected:
	"hashicorp/azurerm" updated from "3.107.0" to "3.108.0" in file ".terraform.lock.hcl"</p> <details> <summary>3.108.0</summary> <pre>Changelog retrieved from:
	https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.108.0
FEATURES:

* **New Data Source:** `azurerm_role_management_policy` ([#25900](hashicorp/terraform-provider-azurerm#25900 **New Resource:** `azurerm_role_management_policy` ([#25900](https://github.com/hashicorp/terraform-provider-azurerm/issues/25900))

ENHANCEMENTS:

* provider: support subscription ID hinting when using Azure CLI authentication ([#26282](hashicorp/terraform-provider-azurerm#26282 `serviceconnector`: updating to use API Version `2024-04-01` ([#26248](hashicorp/terraform-provider-azurerm#26248 `azurerm_container_groups` - can now be created with a User Assigned Identity when running Windows ([#26308](hashicorp/terraform-provider-azurerm#26308 `azurerm_kubernetes_cluster` - updating the `network_profile.network_policy` property to `azure` and `calico` when it hasn't been previously set is supported ([#26176](hashicorp/terraform-provider-azurerm#26176 `azurerm_kubernetes_cluster` - respect Pod Distruption Budgets when rotating the `default_node_pool` ([#26274](hashicorp/terraform-provider-azurerm#26274 `azurerm_lb_backend_address_pool` - support for the `synchronous_mode` property ([#26309](hashicorp/terraform-provider-azurerm#26309 `azurerm_private_endpoint` - support symultaneous creation of multiple resources of this type per subnet ([#26006](https://github.com/hashicorp/terraform-provider-azurerm/issues/26006))

BUG FIXES:

* `azurerm_express_route_circuit_peering`, `azurerm_express_route_circuit`, `azurerm_express_route_gateway`, `azurerm_express_route_port` - split create and update ([#26237](hashicorp/terraform-provider-azurerm#26237 `azurerm_lb_backend_address_pool_address` - when using this resource, values are no longer reset on `azurerm_lb_backend_address_pool` ([#26264](hashicorp/terraform-provider-azurerm#26264 `azurerm_route_filter` - spliting create and update so lifecycle ignore changes works correctly ([#26266](hashicorp/terraform-provider-azurerm#26266 `azurerm_route_server` - spliting create and update so lifecycle ignore changes works correctly ([#26266](hashicorp/terraform-provider-azurerm#26266 `azurerm_synapse_workspace` - updates the client used in all operations of `azurerm_synapse_workspace_sql_aad_admin` to prevent this resource from modifying the same resource as `azurerm_synapse_workspace_aad_admin` ([#26317](hashicorp/terraform-provider-azurerm#26317 `azurerm_virtual_network` - correctly parse network securty group IDs ([#26283](https://github.com/hashicorp/terraform-provider-azurerm/issues/26283))

DEPRECATIONS:

* Data Source: `azurerm_network_interface` - the `enable_ip_forwarding` and `enable_accelerated_networking` properties have been deprecated and superseded by the `ip_forwarding_enabled` and `accelerated_networking_enabled` properties ([#26293](hashicorp/terraform-provider-azurerm#26293 `azurerm_api_management` - the `policy` block has been deprecated is superseded by the `azurerm_api_management_policy` resource ([#26305](hashicorp/terraform-provider-azurerm#26305 `azurerm_kubernetes_cluster` - the `ebpf_data_plane` property has been deprecated and superseded by the `network_data_plane` property ([#26251](hashicorp/terraform-provider-azurerm#26251 `azurerm_network_interface` - the `enable_ip_forwarding` and `enable_accelerated_networking` properties have been deprecated and superseded by the `ip_forwarding_enabled` and `accelerated_networking_enabled` properties ([#26293](hashicorp/terraform-provider-azurerm#26293 `azurerm_synapse_workspace` - the `aad_admin` and `sql_aad_admin` blocks have been deprecated and superseded by the `azurerm_synapse_workspace_aad_admin` and `azurerm_synapse_workspace_sql_aad_admin` resources ([#26317](https://github.com/hashicorp/terraform-provider-azurerm/issues/26317))


</pre> </details> </details> <a href="https://infra.ci.jenkins.io/job/updatecli/job/azure/job/main/244/">Jenkins pipeline link</a> </action> </Actions> --- <table> <tr> <td width="77"> <img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli logo" width="50" height="50"> </td> <td> <p> Created automatically by <a href="https://www.updatecli.io/">Updatecli</a> </p> <details><summary>Options:</summary> <br /> <p>Most of Updatecli configuration is done via <a href="https://www.updatecli.io/docs/prologue/quick-start/">its manifest(s)</a>.</p> <ul> <li>If you close this pull request, Updatecli will automatically reopen it, the next time it runs.</li> <li>If you close this pull request and delete the base branch, Updatecli will automatically recreate it, erasing all previous commits made.</li> </ul> <p> Feel free to report any issues at <a href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br /> If you find this tool useful, do not hesitate to star <a href="https://github.com/updatecli/updatecli/stargazers">our GitHub repository</a> as a sign of appreciation, and/or to tell us directly on our <a href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>! </p> </details> </td> </tr> </table> Co-authored-by: Jenkins Infra Bot (updatecli) <[email protected]>

github-actions · 2024-07-13T02:11:39Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

stephybun added 2 commits June 10, 2024 16:29

remove Computed from dns_servers in 4.0

7f9ce3a

remove computed from dns_server and rename enable_ properties to _ena…

be30e76

…bled

stephybun added enhancement breaking-change service/network-interfaces labels Jun 11, 2024

stephybun added this to the v4.0.0 milestone Jun 11, 2024

github-actions bot added documentation service/network size/L labels Jun 11, 2024

set auxiliary mode and auxiliary sku to nil if it's been removed on a…

58ab2ba

…n update

mbfrahry approved these changes Jun 11, 2024

View reviewed changes

replace deprecated properties in test configs

64f82f3

github-actions bot added service/recovery-services size/XL and removed size/L labels Jun 12, 2024

stephybun merged commit db4bacb into main Jun 12, 2024
33 checks passed

stephybun deleted the f/remove-computed-from-dns-servers branch June 12, 2024 06:46

stephybun added a commit that referenced this pull request Jun 13, 2024

Update #26308 #26305 #26293 #26251

b8e0968

vmisson added a commit to azurerm/terraform-azure-resources that referenced this pull request Jun 17, 2024

Update parameters name for azurerm_network_interface to be compliant …

0f7114c

…with azurerm 4.0 hashicorp/terraform-provider-azurerm#26293

vmisson mentioned this pull request Jun 17, 2024

Update parameters name for azurerm_network_interface to be compliant … azurerm/terraform-azure-resources#42

Merged

github-actions bot locked as resolved and limited conversation to collaborators Jul 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`azurerm_network_interface` - removes `Computed` from `dns_server` and renames `enable_` to `_enabled` #26293

`azurerm_network_interface` - removes `Computed` from `dns_server` and renames `enable_` to `_enabled` #26293

stephybun commented Jun 11, 2024 •

edited

Loading

mbfrahry left a comment

mbfrahry Jun 11, 2024

mbfrahry Jun 11, 2024

mbfrahry commented Jun 11, 2024

stephybun commented Jun 12, 2024

github-actions bot commented Jul 13, 2024

azurerm_network_interface - removes Computed from dns_server and renames enable_* to *_enabled #26293

azurerm_network_interface - removes Computed from dns_server and renames enable_* to *_enabled #26293

Conversation

stephybun commented Jun 11, 2024 • edited Loading

Community Note

Description

Testing

Related Issue(s)

mbfrahry left a comment

Choose a reason for hiding this comment

mbfrahry Jun 11, 2024

Choose a reason for hiding this comment

mbfrahry Jun 11, 2024

Choose a reason for hiding this comment

mbfrahry commented Jun 11, 2024

stephybun commented Jun 12, 2024

github-actions bot commented Jul 13, 2024

`azurerm_network_interface` - removes `Computed` from `dns_server` and renames `enable_` to `_enabled` #26293

`azurerm_network_interface` - removes `Computed` from `dns_server` and renames `enable_` to `_enabled` #26293

stephybun commented Jun 11, 2024 •

edited

Loading