-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_kubernetes_cluster
: Support for upgrade path from Azure CNI to Azure CNI Overlay
#26260
Open
jkroepke
wants to merge
14
commits into
hashicorp:main
Choose a base branch
from
jkroepke:pod-cidr
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+23
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to Azure CNI Overlay
stephybun
reviewed
Jun 10, 2024
@stephybun could you please take a look here? |
Hey, any news here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Description
This PR adds support upgrade-path from Azure CNI to Azure CNI Overlay
Ref: https://learn.microsoft.com/en-us/azure/aks/azure-cni-overlay?tabs=kubectl#azure-cni-cluster-upgrade
PR Checklist
For example: “
resource_name_here
- description of change e.g. adding propertynew_property_name_here
”Changes to existing Resource / Data Source
The existing test
TestAccKubernetesCluster_networkPluginModeUpdate
cover this scenario.Testing
Observing that the upgrade is done in-place:
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_kubernetes_cluster
: Support for upgrade path from Azure CNI to Azure CNI Overlay [GH-00000]This is a (please select all that apply):
Related Issue(s)
Fixes #26259
Note
If this PR changes meaningfully during the course of review please update the title and description as required.