Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data.azurerm_kubernetes_cluster: fix a crash when reading/setting upgrade_settings #26173

Merged

Conversation

manicminer
Copy link
Contributor

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • Data Source: azurerm_kubernetes_cluster - fix a crash when reading/setting upgrade_settings

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #26169

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

@manicminer manicminer requested a review from a team May 31, 2024 17:22
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 📟

@manicminer manicminer added this to the v3.106.1 milestone May 31, 2024
@manicminer manicminer merged commit 2dd1978 into main May 31, 2024
29 checks passed
@manicminer manicminer deleted the bugfix/kubernetes-cluster-data-source-upgrade-settings-crash branch May 31, 2024 17:40
manicminer added a commit that referenced this pull request May 31, 2024
@raswinraaj
Copy link

raswinraaj commented Jun 4, 2024

This seems to have broken the upgrade_settings block in the resource "azurerm_kubernetes_cluster_node_pool". I dont have this block added in my tf code as it is not a mandatory block. Now, Every time , it keeps saying there is a change in my tf plan , but on applying there is no change
image

@manicminer
Copy link
Contributor Author

@raswinraaj Thanks for reporting that, could you please file a new issue for that using our Bug Report template, and someone will look into it.

@raswinraaj
Copy link

@manicminer PFA the new bug for this #26280

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data: azurerm_kubernetes_cluster crash on v3.106
3 participants