-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Data Source: azurerm_storage_table
#26126
Conversation
azurerm_storage_queue
azurerm_storage_queue
azurerm_storage_table
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR @nnstt1! Although I merged #26087 without mentioning that this should actually be a Typed Data Source (I was assuming new contributor unaware of the standards in the provider), as explained in our Contributor Docs, all new Data Sources and Resource should be added as typed ones. We have guides on how to do that here.
Would you mind converting this to a typed Data Sources. Once that's done I can continue with my review. Thanks!
@stephybun Sorry, I overlooked the Contributor Documentation and created the data source by referring to a similar untyped data source. I will update it to a Typed Data Source! I apologize for any trouble this may have caused. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🍔
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Community Note
Description
Adds a new data source
azurerm_storage_table
to retrieve information about an Azure Table Storage.This data source allows referencing and utilizing an existing Azure Table Storage resource.
PR Checklist
For example: “
resource_name_here
- description of change e.g. adding propertynew_property_name_here
”Testing
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_storage_table
[GH-00000]This is a (please select all that apply):
Related Issue(s)
Fixes #25562
Note
If this PR changes meaningfully during the course of review please update the title and description as required.