Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Data Source: azurerm_storage_table #26126

Merged
merged 6 commits into from
May 31, 2024

Conversation

nnstt1
Copy link
Contributor

@nnstt1 nnstt1 commented May 28, 2024

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave "+1" or "me too" comments, they generate extra noise for PR followers and do not help prioritize for review

Description

Adds a new data source azurerm_storage_table to retrieve information about an Azure Table Storage.
This data source allows referencing and utilizing an existing Azure Table Storage resource.

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)
image

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • New Data Source: azurerm_storage_table [GH-00000]

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #25562

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

@nnstt1 nnstt1 changed the title New Data Source: `azurerm_storage_queue New Data Source: azurerm_storage_queue May 28, 2024
@nnstt1 nnstt1 changed the title New Data Source: azurerm_storage_queue New Data Source: azurerm_storage_table May 28, 2024
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @nnstt1! Although I merged #26087 without mentioning that this should actually be a Typed Data Source (I was assuming new contributor unaware of the standards in the provider), as explained in our Contributor Docs, all new Data Sources and Resource should be added as typed ones. We have guides on how to do that here.

Would you mind converting this to a typed Data Sources. Once that's done I can continue with my review. Thanks!

@nnstt1
Copy link
Contributor Author

nnstt1 commented May 29, 2024

@stephybun Sorry, I overlooked the Contributor Documentation and created the data source by referring to a similar untyped data source. I will update it to a Typed Data Source! I apologize for any trouble this may have caused.

@nnstt1 nnstt1 requested a review from stephybun May 29, 2024 15:28
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍔

@katbyte katbyte merged commit c32a5ed into hashicorp:main May 31, 2024
33 checks passed
@github-actions github-actions bot added this to the v3.106.0 milestone May 31, 2024
katbyte added a commit that referenced this pull request May 31, 2024
Copy link

github-actions bot commented Jul 1, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_storage_table data source
3 participants