Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributor Documentation: Add section on composite resource IDs #25976

Merged
merged 4 commits into from
May 16, 2024

Conversation

stephybun
Copy link
Member

@stephybun stephybun commented May 15, 2024

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave "+1" or "me too" comments, they generate extra noise for PR followers and do not help prioritize for review

Description

The examples in the resource and data source guides were outdated, using functions and processes that we're phasing out. This PR updates those examples, as well as removes redundant comments in the examples.

Also added a section on resource IDs, specifically Composite Resource IDs which can now become a new standard in the provider for scoped resource IDs containing |.

Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stephybun - Couple minor comments, otherwise LGTM 🦃

contributing/topics/guide-new-fields-to-resource.md Outdated Show resolved Hide resolved
contributing/topics/guide-resource-ids.md Outdated Show resolved Hide resolved
stephybun and others added 2 commits May 16, 2024 08:48
Co-authored-by: jackofallops <[email protected]>
Co-authored-by: jackofallops <[email protected]>
@stephybun stephybun merged commit 01c781d into main May 16, 2024
2 checks passed
@stephybun stephybun deleted the docs/update-contributor-docs branch May 16, 2024 06:49
@github-actions github-actions bot added this to the v3.104.0 milestone May 16, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants