[MS] Added default caching value as expected by API - fixing #224 #259
Conversation
There was a problem hiding this comment.
Hey @echuvyrov
Thanks for this PR - this is a good catch, if we can make the default value string(compute.None) to make the compiler happy then this otherwise LGTM :)
Thanks!
azurerm/resource_arm_image.go
Outdated
| @@ -83,7 +83,7 @@ func resourceArmImage() *schema.Resource { | |||
| "caching": { | |||
| Type: schema.TypeString, | |||
| Optional: true, | |||
| Computed: true, | |||
| Default: compute.None, | |||
There was a problem hiding this comment.
I think this needs to be string(compute.None) or compilation will fail?
|
hey @tombuildsstuff changes made :) |
There was a problem hiding this comment.
Hey @echuvyrov
Thanks for pushing that update - this LGTM :)
|
Fixes #224 |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
The managed disk was recreated on every run if "caching" parameter was missing. This PR should address that (bug documented here #224)