azurerm_storage_account: add retry when retrieving web static properties response 404 Not Found

[wuxu92]

…create sa issue

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave "+1" or "me too" comments, they generate extra noise for PR followers and do not help prioritize for review

Description

The accountsClient.GetServiceProperties call consistently returns a 404 Not Found error when attempting to destroy and then create a storage account with the same name. This PR aims to include a retry call in order to prevent the unexpected occurrence of this error. If the resource is still not found after the retry, an error will be raised, ensuring that issue #20257 is not overlooked. This is a improvement of #19062 and serves as a fix for #24982.

        Error: retrieving static website properties for Storage Account (Subscription: "xxx"
        Resource Group Name: "acctestRG-storage-240429173322807028"
        Storage Account Name: "unlikely23exst2acct20lxz"): executing request: unexpected status 404 (404 The specified resource does not exist.) with ResourceNotFound: The specified resource does not exist.
        RequestId:48abb5e8-a01e-0053-0e18-9a123d000000
        Time:2024-04-29T09:37:30.3373663Z



          with azurerm_storage_account.test,
          on terraform_plugin_test.tf line 30, in resource "azurerm_storage_account" "test":
          30: resource "azurerm_storage_account" "test" {

Just found that #23002 fixes the same issue but not updated for a while. I/m ok to close my PR if #23002 is going to be merged.

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevent documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

--- PASS: TestAccStorageAccount_basicDestroy (353.03s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/storage    353.040s

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_storage_account - fix the error of retrieving static website properties for Storage Account xxx: executing request: unexpected status 404 (404 The specified resource does not exist.) with ResourceNotFound when recreate a storage account with the same name.

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #24982

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[tombuildsstuff]

hey @wuxu92

Thanks for this PR / apologies for the delayed response here.

I've recently been porting the remaining Storage resources over to hashicorp/go-azure-sdk and have just opened #26218 which does refactors these.

As a part of this work I've also taken a look into both this PR and #23002 - and ended up incorporating a fix for the underlying issue into that #26218.

As such whilst I'd like to thank you for this contribution, since there's some pretty substantial changes happening to the Storage resources in #26218 and a fix for #22992 is included within that PR - I hope you don't mind but I'm going to close this PR in favour of #26218 - which ultimately fixes #22992.

Thanks!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.