-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Service Fabric Reverse Proxy Certificate and Endpoint in Nodetype #2544
Added Service Fabric Reverse Proxy Certificate and Endpoint in Nodetype #2544
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @joranm,
Thank you for this contribution! The tests pass and it LGTM aside from the lack of documentation. Once we get that updated it should be good to merge 🙂
Hi @katbyte, updated the website documentation according to the additions of the reverse proxy certificate and endpoint. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @joranm, LGTM now 🙂
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Added reverse_proxy_certificate and reverse_proxy_endpoint_port to the azurerm_service_fabric_cluster resource.