azurerm_storage_account - Extend the support level of (blob|queue|share)_properties for Storage kind

[magodo]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave "+1" or "me too" comments, they generate extra noise for PR followers and do not help prioritize for review

Description

Update document of azurerm_storage_account for the viable combinations for (queue|share)_properties

azurerm_storage_account - Extend the support level of (blob|queue|share)_properties for Storage kind

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevent documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

terraform-provider-azurerm on  storage_tier_kind_doc via 🐹 v1.22.1
💤  TF_ACC=1 go test -v -timeout=20h ./internal/services/storage -run='TestAccStorageAccount_StorageV1_'
=== RUN   TestAccStorageAccount_StorageV1_blobProperties
=== PAUSE TestAccStorageAccount_StorageV1_blobProperties
=== RUN   TestAccStorageAccount_StorageV1_queueProperties
=== PAUSE TestAccStorageAccount_StorageV1_queueProperties
=== RUN   TestAccStorageAccount_StorageV1_shareProperties
=== PAUSE TestAccStorageAccount_StorageV1_shareProperties
=== CONT  TestAccStorageAccount_StorageV1_blobProperties
=== CONT  TestAccStorageAccount_StorageV1_shareProperties
=== CONT  TestAccStorageAccount_StorageV1_queueProperties
--- PASS: TestAccStorageAccount_StorageV1_blobProperties (143.56s)
--- PASS: TestAccStorageAccount_StorageV1_queueProperties (158.50s)
--- PASS: TestAccStorageAccount_StorageV1_shareProperties (159.78s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/storage       159.808s

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_storage_account - Extend the support level of (blob|queue|share)_properties for Storage kind [GH-00000]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #25422

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[tombuildsstuff]

Could we rephrase these to be clearer?

[rcskosir]

@magodo 👋 Thank you for using our new PR template! Can you please update the template to include the description for this PR under the description heading? This helps with the review process as well as traceability in the future for our users.

[tombuildsstuff]

Otherwise LGTM 👍

[MedFazazi]

Hi there, have you had a chance to check out my comment on this issue?

#25422 (comment)

[magodo]

@tombuildsstuff As @MedFazazi has mentioned, our existing feature check didn't account for the kind Storage, I've modified my PR to extend the support level of (blob|queue|share)_properties for Storage kind then. Please take another look!

[MedFazazi]

Hello @magodo,
Thank you for your efforts in extending the support level for blob_properties, queue_properties, and share_properties to the Storage kind. I wanted to kindly inquire if there's a possibility to also include support for configuring table_properties, including logging features, in Azure Storage Accounts. The ability to manage table service properties, including logging, through Terraform would greatly enhance its usability for various use cases.

Additionally, I would like to draw attention to issue #3581, which seems to be in the same context

Thank you for considering this request!

Warm regards,

[tombuildsstuff]

Left a couple of comments around the docs but otherwise 👍

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.