Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_network_manager_deployment - add parallel locks #25368

Merged
merged 2 commits into from
Mar 26, 2024
Merged

azurerm_network_manager_deployment - add parallel locks #25368

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
505b301
add parallel locks for deployment with same ID
teowa Mar 22, 2024
28d699a
add lock in delete/update
teowa Mar 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions internal/services/network/network_manager_deployment_resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import (
"github.com/hashicorp/go-azure-helpers/resourcemanager/location"
"github.com/hashicorp/go-azure-sdk/resource-manager/network/2023-09-01/networkmanagers"
"github.com/hashicorp/terraform-provider-azurerm/helpers/azure"
"github.com/hashicorp/terraform-provider-azurerm/internal/locks"
"github.com/hashicorp/terraform-provider-azurerm/internal/sdk"
"github.com/hashicorp/terraform-provider-azurerm/internal/services/network/parse"
"github.com/hashicorp/terraform-provider-azurerm/internal/services/network/validate"
Expand Down Expand Up @@ -108,6 +109,9 @@ func (r ManagerDeploymentResource) Create() sdk.ResourceFunc {
normalizedLocation := azure.NormalizeLocation(state.Location)
id := parse.NewNetworkManagerDeploymentID(networkManagerId.SubscriptionId, networkManagerId.ResourceGroupName, networkManagerId.NetworkManagerName, normalizedLocation, state.ScopeAccess)

locks.ByID(id.ID())
defer locks.UnlockByID(id.ID())
Comment on lines +112 to +113
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll need these during Update and Delete too?


metadata.Logger.Infof("creating %s", *id)

listParam := networkmanagers.NetworkManagerDeploymentStatusParameter{
Expand Down
Loading