Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firewall app rules #2532

Merged
merged 18 commits into from
Jan 4, 2019
Merged

Firewall app rules #2532

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
fa7fb5b
add application rule collection
hbuckle Dec 6, 2018
02585fe
add application rule collection
hbuckle Dec 6, 2018
ff85b13
Merge branch 'firewall_app_rules' of https://github.com/hbuckle/terra…
hbuckle Dec 7, 2018
ec01897
rename some vars
hbuckle Dec 7, 2018
d6cfdf4
add test skeleton
hbuckle Dec 7, 2018
0a92f11
use list instead of set
hbuckle Dec 7, 2018
22f39b3
add all the tests
hbuckle Dec 7, 2018
b1ddeb7
Merge branch 'master' into firewall_app_rules
hbuckle Dec 18, 2018
80800ca
remove comment
hbuckle Dec 18, 2018
cb8ed88
line ending
hbuckle Dec 18, 2018
5b01614
docs
hbuckle Dec 20, 2018
8ef53d6
add validation to rule expand
hbuckle Dec 28, 2018
c2932ec
use utility functions
hbuckle Jan 2, 2019
8884d81
move sliceToSet to helpers
hbuckle Jan 2, 2019
10bbff7
fix the check attributes
hbuckle Jan 2, 2019
cc0a5e2
move required properties up
hbuckle Jan 2, 2019
3efa63c
update error message
hbuckle Jan 3, 2019
c485797
update error message
hbuckle Jan 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions azurerm/helpers/set/set.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,3 +33,11 @@ func ToSliceInt32P(set *schema.Set) *[]int32 {

return &slice
}

func FromStringSlice(slice []string) *schema.Set {
set := &schema.Set{F: schema.HashString}
for _, v := range slice {
set.Add(v)
}
return set
}
1 change: 1 addition & 0 deletions azurerm/provider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,7 @@ func Provider() terraform.ResourceProvider {
"azurerm_express_route_circuit_peering": resourceArmExpressRouteCircuitPeering(),
"azurerm_firewall": resourceArmFirewall(),
"azurerm_firewall_network_rule_collection": resourceArmFirewallNetworkRuleCollection(),
"azurerm_firewall_application_rule_collection": resourceArmFirewallApplicationRuleCollection(),
"azurerm_function_app": resourceArmFunctionApp(),
"azurerm_image": resourceArmImage(),
"azurerm_iothub": resourceArmIotHub(),
Expand Down
Loading