-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_synapse_spark_pool
- added spark pool 3.4 support for Synapse
#25319
azurerm_synapse_spark_pool
- added spark pool 3.4 support for Synapse
#25319
Conversation
azurerm_synapse_spark_pool
- added spark pool 3.4 support for Synapse
I think this is the way. Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @daniel-brown-improving, this PR looks good but we shouldn't change the default behavior between minor versions as that could break people.
Oh my. I didn't realize this PR would be such a hot topic! Apologies for the double review @daniel-brown-improving! |
Removing deprecation language from docs Co-authored-by: Matthew Frahry <mbfrahry@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for pushing those changes @daniel-brown-improving
No worries. I'm glad you guys care that much. |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Created Issue for this: #25318
Updated
azurerm_synapse_spark_pool
resource to add support forspark_pool_version 3.4
. Also, updated the default version to be3.4
, which is the latest version.