#24910: Use ParseFirewallPolicyIDInsensitively for parsing API response #24913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tombuildsstuff
approved these changes
Feb 16, 2024
There was a problem hiding this comment.
hey @harshavmb
Thanks for this PR - I've left one comment inline about returning the error if it's returned but otherwise this LGTM 👍
Thanks!
|
Hi @tombuildsstuff , Made the change! Over to you for the re-review. |
katbyte
approved these changes
Feb 16, 2024
rizkybiz
pushed a commit
to rizkybiz/terraform-provider-azurerm
that referenced
this pull request
Feb 21, 2024
…PI response (hashicorp#24913) * hashicorp#24910: Use ParseFirewallPolicyIDInsensitively for parsing API response * hashicorp#24910: capturing and returning error as per review
rizkybiz
pushed a commit
to rizkybiz/terraform-provider-azurerm
that referenced
this pull request
Feb 29, 2024
…PI response (hashicorp#24913) * hashicorp#24910: Use ParseFirewallPolicyIDInsensitively for parsing API response * hashicorp#24910: capturing and returning error as per review
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
ParseFirewallPolicyIDInsensitivelyfor parsing API response ratherParseFirewallPolicyIDas per below comment mentioned here.Reads are from API response, so
ParseFirewallPolicyIDInsensitivelyneeds to be used.Fixes #24910.