Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubernetes_cluster_* - fix tests with ctx deadline #24886

Merged
merged 4 commits into from
Feb 15, 2024
Merged

kubernetes_cluster_* - fix tests with ctx deadline #24886

merged 4 commits into from
Feb 15, 2024

Conversation

catriona-m
Copy link
Member

Fix tests broken by Container Services base layer change in #24872

------- Stdout: -------
=== RUN   TestAccKubernetesClusterNodePool_manualScaleIgnoreChanges
=== PAUSE TestAccKubernetesClusterNodePool_manualScaleIgnoreChanges
=== CONT  TestAccKubernetesClusterNodePool_manualScaleIgnoreChanges
    testcase.go:113: Step 1/2 error: Check failed: Check 3/3 error: Check 1/1 error: Bad: Get on agentPoolsClient: the context used must have a deadline attached for polling purposes, but got no deadline
--- FAIL: TestAccKubernetesClusterNodePool_manualScaleIgnoreChanges (735.68s)
FAIL

tombuildsstuff
tombuildsstuff approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@catriona-m catriona-m merged commit 66915e2 into main Feb 15, 2024
30 checks passed
@catriona-m catriona-m deleted the cm/csfix branch February 15, 2024 16:37
@github-actions github-actions bot added this to the v3.92.0 milestone Feb 15, 2024
rizkybiz pushed a commit to rizkybiz/terraform-provider-azurerm that referenced this pull request Feb 21, 2024
@catriona-m @rizkybiz
kubernetes_cluster_* - fix tests with ctx deadline (hashicorp#24886)
59f8cab 
* add context with deadline to tests

* add context with deadline to tests

* sort imports

* add context with deadline
rizkybiz pushed a commit to rizkybiz/terraform-provider-azurerm that referenced this pull request Feb 29, 2024
@catriona-m @rizkybiz
kubernetes_cluster_* - fix tests with ctx deadline (hashicorp#24886)
d251ea9 
* add context with deadline to tests

* add context with deadline to tests

* sort imports

* add context with deadline
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
v3.92.0
Development

Successfully merging this pull request may close these issues.
2 participants
@catriona-m @tombuildsstuff