Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve azure_lb_rule docs #24827

Merged
merged 4 commits into from
Feb 9, 2024
Merged

Improve azure_lb_rule docs #24827

merged 4 commits into from
Feb 9, 2024

Conversation

codycodes
Copy link
Contributor

Small improvements:

  • A note on what using a port of 0 means for the rule (any port)
  • A typo

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @codycodes - aside from a little note on the wording this LGTM 🍵

website/docs/r/lb_rule.html.markdown Outdated Show resolved Hide resolved
website/docs/r/lb_rule.html.markdown Outdated Show resolved Hide resolved
@katbyte katbyte merged commit 325f61b into hashicorp:main Feb 9, 2024
5 of 6 checks passed
@github-actions github-actions bot added this to the v3.91.0 milestone Feb 9, 2024
rizkybiz pushed a commit to rizkybiz/terraform-provider-azurerm that referenced this pull request Feb 29, 2024
* ✏️ tiny typo

* Add note for 0 = "Any Port"

* Update website/docs/r/lb_rule.html.markdown

* Update website/docs/r/lb_rule.html.markdown

---------

Co-authored-by: kt <[email protected]>
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 24, 2024
@codycodes codycodes deleted the improve-docs branch November 21, 2024 20:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants