Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate 'Display Name' for API Management's named values #24749

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

CSymes
Copy link
Contributor

@CSymes CSymes commented Feb 2, 2024

When creating a new Named Value through APIM in the Azure portal, an apparently undocumented naming restriction is noted regarding its display name:
image

When applying a plan containing a named value with a non-compliant display name, this would previously plan as valid, then fail with an ambiguous performing CreateOrUpdate: unexpected status 400 with error: ValidationError: One or more fields contain incorrect values.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @CSymes ! LGTM 💣

@katbyte katbyte merged commit c540700 into hashicorp:main Feb 9, 2024
29 checks passed
@github-actions github-actions bot added this to the v3.91.0 milestone Feb 9, 2024
@alexwiese
Copy link
Contributor

@katbyte @CSymes
I’m seeing validation errors now with display names that satisfy the requirements.
wouldn’t this new regex only match a single character?

display names can be more than one character

@CSymes
Copy link
Contributor Author

CSymes commented Feb 10, 2024

@alexwiese thanks for fixing that - not sure how that slipped through!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants