Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TestCase] Fix TestAccCosmosDbPostgreSQLCluster_complete and TestAccCosmosDbPostgreSQLCluster_update #24649

Merged
merged 2 commits into from
Jan 26, 2024
Merged

[TestCase] Fix TestAccCosmosDbPostgreSQLCluster_complete and TestAccCosmosDbPostgreSQLCluster_update #24649

merged 2 commits into from
Jan 26, 2024

Conversation

neil-yechenwei
Copy link
Contributor

@neil-yechenwei neil-yechenwei commented Jan 26, 2024 •
edited
Loading

Recently these two test cases are failed in Teamcity Daily Run. So I raised this PR to fix it.

--- PASS: TestAccCosmosDbPostgreSQLCluster_complete (1405.13s)
--- PASS: TestAccCosmosDbPostgreSQLCluster_update (3473.88s)

stephybun
stephybun reviewed Jan 26, 2024
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @neil-yechenwei.

Why do these values need to change? These tests were passing in November last year. Did something change service side?

@neil-yechenwei
Copy link
Contributor Author

neil-yechenwei commented Jan 26, 2024 •
edited
Loading

@stephybun , I assume yes. Recently these two test cases keep failing in Teamcity Daily Run. I found that the combination of the minimum values of coordinator_vcore_count, coordinator_storage_quota_in_mb, node_storage_quota_in_mb and node_vcores are changed/increased. See more details from https://ms.portal.azure.com/#home.

@stephybun
Copy link
Member

@neil-yechenwei do you have another link or a screenshot? That link just open the azure portal for me.

@neil-yechenwei
Copy link
Contributor Author

neil-yechenwei commented Jan 26, 2024 •
edited
Loading

@stephybun , you can test the combination via https://ms.portal.azure.com/#browse/Microsoft.DBforPostgreSQL%2FserverGroupsv2.

image
image

stephybun
stephybun approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification @neil-yechenwei LGTM 👍

@stephybun stephybun merged commit cfe2aae into hashicorp:main Jan 26, 2024
30 checks passed
@github-actions github-actions bot added this to the v3.90.0 milestone Jan 26, 2024
rizkybiz pushed a commit to rizkybiz/terraform-provider-azurerm that referenced this pull request Jan 30, 2024
@neil-yechenwei @rizkybiz
[TestCase] Fix TestAccCosmosDbPostgreSQLCluster_complete and TestAccC…
77c30e8 
…osmosDbPostgreSQLCluster_update (hashicorp#24649)

* [TestCase] Fix TestAccCosmosDbPostgreSQLCluster_complete and TestAccCosmosDbPostgreSQLCluster_update

* [TestCase] Fix TestAccCosmosDbPostgreSQLCluster_complete and TestAccCosmosDbPostgreSQLCluster_update
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephybun stephybun stephybun approved these changes

Assignees
No one assigned
Labels
service/cosmosdb size/XS tests
Projects
None yet
Milestone
v3.90.0
Development

Successfully merging this pull request may close these issues.
2 participants
@neil-yechenwei @stephybun