Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix datalake doc examples & touch up service bus doc examples #2449

Merged
merged 5 commits into from
Dec 5, 2018

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Dec 5, 2018

fixes #1681
fixes #1684

@katbyte katbyte added this to the 1.20.0 milestone Dec 5, 2018
@katbyte katbyte requested a review from WodansSon December 5, 2018 05:39
@ghost ghost added the size/L label Dec 5, 2018
Copy link
Collaborator

@WodansSon WodansSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@katbyte this looks really good, I really like the idea of the tfex prefix! Left a few comments on the PR, let me know what you think. Really minor, and none of the merge blockers in my eye.

website/docs/r/data_lake_analytics_account.html.markdown Outdated Show resolved Hide resolved
website/docs/r/servicebus_subscription.html.markdown Outdated Show resolved Hide resolved
website/docs/r/servicebus_subscription_rule.html.markdown Outdated Show resolved Hide resolved
website/docs/r/servicebus_subscription_rule.html.markdown Outdated Show resolved Hide resolved
website/docs/r/servicebus_topic.html.markdown Outdated Show resolved Hide resolved
@WodansSon WodansSon merged commit 96a89fd into master Dec 5, 2018
@WodansSon WodansSon deleted the d/datalake branch December 5, 2018 06:41
@ghost
Copy link

ghost commented Mar 5, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants