Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/application_gateway: components within the url block is no longer computed #24480

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

tombuildsstuff
Copy link
Contributor

This allows this field to be unset in the configuration, which equates to both.

This field doesn't actually exist in the API and is used purely to determine which fields should be set/have a value - so marking this as un-computed should be fine.

…er computed

This allows this field to be unset in the configuration, which equates to `both`.

This field doesn't actually exist in the API and is used purely to determine which
fields should be set/have a value - so marking this as un-computed should be fine.
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍰

@tombuildsstuff tombuildsstuff merged commit df376d5 into main Jan 17, 2024
29 checks passed
@tombuildsstuff tombuildsstuff deleted the b/application-gateway-components branch January 17, 2024 18:00
tombuildsstuff added a commit that referenced this pull request Jan 17, 2024
dduportal pushed a commit to jenkins-infra/azure that referenced this pull request Jan 19, 2024
<Actions>
<action
id="f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8">
        <h3>Bump Terraform `azurerm` provider version</h3>
<details
id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24">
            <summary>Update Terraform lock file</summary>
<p>&#34;hashicorp/azurerm&#34; updated from &#34;3.87.0&#34; to
&#34;3.88.0&#34; in file &#34;.terraform.lock.hcl&#34;</p>
            <details>
                <summary>3.88.0</summary>
<pre>Changelog retrieved
from:&#xA;&#x9;https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.88.0&#xA;FEATURES:&#xA;&#xA;*
New Data Source: `azurerm_nginx_deployment`
([#24492](hashicorp/terraform-provider-azurerm#24492
New Resource:
`azurerm_spring_cloud_dynatrace_application_performance_monitoring`
([#23889](hashicorp/terraform-provider-azurerm#23889
New Resource: `azurerm_virtual_machine_run_command`
([#23377](https://github.com/hashicorp/terraform-provider-azurerm/issues/23377))&#xA;&#xA;ENHANCEMENTS:&#xA;&#xA;*
dependencies: updating to `v0.20240117.1163544` of
`github.com/hashicorp/go-azure-sdk`
([#24481](hashicorp/terraform-provider-azurerm#24481
dependencies: updating to `v0.65.1` of
`github.com/hashicorp/go-azure-helpers`
([#24479](hashicorp/terraform-provider-azurerm#24479
`datashare`: updating to use the base layer from
`hashicorp/go-azure-sdk` rather than `Azure/go-autorest`
([#24481](hashicorp/terraform-provider-azurerm#24481
`kusto`: updating to use the base layer from `hashicorp/go-azure-sdk`
rather than `Azure/go-autorest`
([#24477](hashicorp/terraform-provider-azurerm#24477
Data Source: `azurerm_application_gateway` - support for the
`trusted_client_certificate.data` property
([#24474](hashicorp/terraform-provider-azurerm#24474
`azurerm_service_plan`: refactoring to use `hashicorp/go-azure-sdk`
([#24483](hashicorp/terraform-provider-azurerm#24483
`azurerm_container_group` - support for the `priority` property
([#24374](hashicorp/terraform-provider-azurerm#24374
`azurerm_mssql_managed_database` - support for the
`point_in_time_restore` property
([#24535](hashicorp/terraform-provider-azurerm#24535
`azurerm_mssql_managed_instance` - now exports the `dns_zone` attribute
([#24435](hashicorp/terraform-provider-azurerm#24435
`azurerm_linux_web_app_slot` - support for setting `python_version` to
`3.12`
([#24363](hashicorp/terraform-provider-azurerm#24363
`azurerm_linux_web_app` - support for setting `python_version` to `3.12`
([#24363](hashicorp/terraform-provider-azurerm#24363
`azurerm_linux_function_app_slot` - support for setting `python_version`
to `3.12`
([#24363](hashicorp/terraform-provider-azurerm#24363
`azurerm_linux_function_app` - support for setting `python_version` to
`3.12`
([#24363](https://github.com/hashicorp/terraform-provider-azurerm/issues/24363))&#xA;&#xA;BUG
FIXES:&#xA;&#xA;* `azurerm_application_gateway` - the `components`
property within the `url` block is no longer computed
([#24480](hashicorp/terraform-provider-azurerm#24480
`azurerm_cdn_frontdoor_route` - prevent an issue where
`cdn_frontdoor_origin_path` gets removed on update if unchanged.
([#24488](hashicorp/terraform-provider-azurerm#24488
`azurerm_cognitive_account` - fixing support for the `DC0` SKU
([#24526](https://github.com/hashicorp/terraform-provider-azurerm/issues/24526))&#xA;&#xA;&#xA;</pre>
            </details>
        </details>
<a
href="https://infra.ci.jenkins.io/job/terraform-jobs/job/azure/job/main/1017/">Jenkins
pipeline link</a>
    </action>
</Actions>

---

<table>
  <tr>
    <td width="77">
<img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli
logo" width="50" height="50">
    </td>
    <td>
      <p>
Created automatically by <a
href="https://www.updatecli.io/">Updatecli</a>
      </p>
      <details><summary>Options:</summary>
        <br />
<p>Most of Updatecli configuration is done via <a
href="https://www.updatecli.io/docs/prologue/quick-start/">its
manifest(s)</a>.</p>
        <ul>
<li>If you close this pull request, Updatecli will automatically reopen
it, the next time it runs.</li>
<li>If you close this pull request and delete the base branch, Updatecli
will automatically recreate it, erasing all previous commits made.</li>
        </ul>
        <p>
Feel free to report any issues at <a
href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br
/>
If you find this tool useful, do not hesitate to star <a
href="https://github.com/updatecli/updatecli/stargazers">our GitHub
repository</a> as a sign of appreciation, and/or to tell us directly on
our <a
href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>!
        </p>
      </details>
    </td>
  </tr>
</table>

Co-authored-by: Jenkins Infra Bot (updatecli) <60776566+jenkins-infra-bot@users.noreply.github.com>
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants