Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#24358: Support vm_template for azurerm_virtual_desktop_host_pool resource #24369

Merged
merged 4 commits into from
Feb 16, 2024
Merged

#24358: Support vm_template for azurerm_virtual_desktop_host_pool resource #24369

merged 4 commits into from
Feb 16, 2024

Conversation

harshavmb
Copy link
Contributor

Support vm_template for azurerm_virtual_desktop_host_pool resource.

Fixes #24358.

catriona-m
catriona-m requested changes Jan 10, 2024
View reviewed changes
Copy link
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @harshavmb, I've left a couple of minor comments but once those are fixed up I can take another look. It would also be good to include this property in a test. Thanks!

internal/services/desktopvirtualization/virtual_desktop_host_pool_resource.go Outdated Show resolved Hide resolved
website/docs/r/virtual_desktop_host_pool.html.markdown Outdated Show resolved Hide resolved
@harshavmb
Copy link
Contributor Author

Hi @catriona-m ,

Indeed I wanted to add a test case but couldn't find some documentation about vm_template. Also my organization has restricted has restricted access to create AVDs.

I shall check with the request initiator if he could provide me a sample template to play with.

@harshavmb harshavmb requested a review from catriona-m January 10, 2024 17:34
@catriona-m
Copy link
Member

HI @harshavmb - just checking in to see if you were able to get the config needed to create a test for this? Thanks!

@harshavmb
Copy link
Contributor Author

HI @harshavmb - just checking in to see if you were able to get the config needed to create a test for this? Thanks!

Hi @catriona-m ,

I have added the test case now. Could you please re-review?

@katbyte katbyte changed the title #24358: Support vmTemplate for azurerm_virtual_desktop_host_pool resource #24358: Support vm_template for azurerm_virtual_desktop_host_pool resource Feb 16, 2024
katbyte
katbyte approved these changes Feb 16, 2024
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @harshavmb - LGTM 🖥️

@katbyte katbyte merged commit f72bb19 into hashicorp:main Feb 16, 2024
33 checks passed
@github-actions github-actions bot added this to the v3.92.0 milestone Feb 16, 2024
katbyte added a commit that referenced this pull request Feb 16, 2024
@katbyte
Update CHANGELOG.md #24369
b27ecf8
dduportal referenced this pull request in jenkins-infra/azure Feb 19, 2024
@jenkins-infra-updatecli @jenkins-infra-bot @dduportal
Bump Terraform azurerm provider version to 3.92.0 (#619)
0d28215 
<Actions>
<action
id="f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8">
        <h3>Bump Terraform `azurerm` provider version</h3>
<details
id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24">
            <summary>Update Terraform lock file</summary>
<p>changes detected:&#xA;&#x9;&#34;hashicorp/azurerm&#34; updated from
&#34;3.91.0&#34; to &#34;3.92.0&#34; in file
&#34;.terraform.lock.hcl&#34;</p>
            <details>
                <summary>3.92.0</summary>
<pre>Changelog retrieved
from:&#xA;&#x9;https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.92.0&#xA;FEATURES:&#xA;&#xA;*
**New Data Source**: `azurerm_virtual_desktop_application_group`
([#24771](https://github.com/hashicorp/terraform-provider-azurerm/issues/24771))&#xA;&#xA;ENHANCEMENTS:&#xA;&#xA;*
provider: support for the feature flag
`postgresql_flexible_server.restart_server_on_configuration_value_change
property`
([#23811](hashicorp/terraform-provider-azurerm#23811
dependencies: updating to v0.20240214.1142753 of
`github.com/hashicorp/go-azure-sdk`
([#24889](hashicorp/terraform-provider-azurerm#24889
`automation`: updating to use the transport layer from
`hashicorp/go-azure-sdk` rather than `Azure/go-autorest`
([#24858](hashicorp/terraform-provider-azurerm#24858
`maintenance`: updating to use the transport layer from
`hashicorp/go-azure-sdk` rather than `Azure/go-autorest`
([#24819](hashicorp/terraform-provider-azurerm#24819
`containerapps`: updating to use the transport layer from
`hashicorp/go-azure-sdk` rather than `Azure/go-autorest`
([#24862](hashicorp/terraform-provider-azurerm#24862
`containerservices`: updating to use the transport layer from
`hashicorp/go-azure-sdk` rather than `Azure/go-autorest`
([#24872](hashicorp/terraform-provider-azurerm#24872
`timeseriesinsights`: updating to use the transport layer from
`hashicorp/go-azure-sdk` rather than `Azure/go-autorest`
([#24889](hashicorp/terraform-provider-azurerm#24889
`azurerm_container_app_environment`: support for the
`infrastructure_resource_group_name` property
([#24361](hashicorp/terraform-provider-azurerm#24361
`azurerm_cost_anomaly_alert` - support for the `subscription_id`
property
([#24258](hashicorp/terraform-provider-azurerm#24258
`azurerm_cosmosdb_account` - add default values for the
`consistency_policy` code block
([#24830](hashicorp/terraform-provider-azurerm#24830
`azurerm_dashboard_grafana` - support for the `smtp` block
([#24717](hashicorp/terraform-provider-azurerm#24717
`azurerm_key_vault_certificates` - support for the `tags` property
([#24857](hashicorp/terraform-provider-azurerm#24857
`azurerm_key_vault_secrets` - support for the `tags` property
([#24857](hashicorp/terraform-provider-azurerm#24857
`azurerm_orchestrated_virtual_machine_scale_set` - support for the
`additional_unattend_content` block
([#24292](hashicorp/terraform-provider-azurerm#24292
`azurerm_virtual_desktop_host_pool` - support for the `vm_template`
property
([#24369](https://github.com/hashicorp/terraform-provider-azurerm/issues/24369))&#xA;&#xA;BUG
FIXES:&#xA;&#xA;* `azurerm_container_app_environment`: avoid unwanted
changes when updating and using `log_analytics_workspace_id`
([#24303](hashicorp/terraform-provider-azurerm#24303
`azurerm_cosmosdb_account` - fixed regression in the `backup` code block
([#24830](hashicorp/terraform-provider-azurerm#24830
`azurerm_data_factory` - allow the `git_url` property to be blank/empty
([#24879](hashicorp/terraform-provider-azurerm#24879
`azurerm_linux_web_app_slot` - the `worker_count` property now works
correctly in the `site_config` block
([#24515](hashicorp/terraform-provider-azurerm#24515
`azurerm_linux_web_app` - support `off` for the `file_system_level`
property
([#24877](hashicorp/terraform-provider-azurerm#24877
`azurerm_linux_web_app_slot` - support `off` for the `file_system_level`
property
([#24877](hashicorp/terraform-provider-azurerm#24877
`azurerm_private_endpoint` - fixing an issue where updating the Private
Endpoint would remove any Application Security Group Association
([#24846](hashicorp/terraform-provider-azurerm#24846
`azurerm_search_service` - fixed the update function to adjust for
changed API behaviour
([#24837](hashicorp/terraform-provider-azurerm#24837
`azurerm_search_service` - fixed the update function to adjust for
changed API behaviour
([#24903](hashicorp/terraform-provider-azurerm#24903
`azurerm_windows_web_app` - support `off` for the `file_system_level`
property
([#24877](hashicorp/terraform-provider-azurerm#24877
`azurerm_windows_web_app_slot` - support `off` for the
`file_system_level` property
([#24877](https://github.com/hashicorp/terraform-provider-azurerm/issues/24877))&#xA;&#xA;&#xA;</pre>
            </details>
        </details>
<a
href="https://infra.ci.jenkins.io/job/updatecli/job/azure/job/main/3/">Jenkins
pipeline link</a>
    </action>
</Actions>

---

<table>
  <tr>
    <td width="77">
<img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli
logo" width="50" height="50">
    </td>
    <td>
      <p>
Created automatically by <a
href="https://www.updatecli.io/">Updatecli</a>
      </p>
      <details><summary>Options:</summary>
        <br />
<p>Most of Updatecli configuration is done via <a
href="https://www.updatecli.io/docs/prologue/quick-start/">its
manifest(s)</a>.</p>
        <ul>
<li>If you close this pull request, Updatecli will automatically reopen
it, the next time it runs.</li>
<li>If you close this pull request and delete the base branch, Updatecli
will automatically recreate it, erasing all previous commits made.</li>
        </ul>
        <p>
Feel free to report any issues at <a
href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br
/>
If you find this tool useful, do not hesitate to star <a
href="https://github.com/updatecli/updatecli/stargazers">our GitHub
repository</a> as a sign of appreciation, and/or to tell us directly on
our <a
href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>!
        </p>
      </details>
    </td>
  </tr>
</table>

Co-authored-by: Jenkins Infra Bot (updatecli) <[email protected]>
Co-authored-by: Damien Duportal <[email protected]>
@harshavmb harshavmb deleted the github-24358 branch February 20, 2024 13:44
@rcskosir rcskosir mentioned this pull request Feb 20, 2024
Closed
1 task
rizkybiz pushed a commit to rizkybiz/terraform-provider-azurerm that referenced this pull request Feb 21, 2024
@harshavmb @rizkybiz
hashicorp#24358: Support vm_template for azurerm_virtual_desktop_host…
0a819f3 
…_pool resource (hashicorp#24369)

* hashicorp#24358: Support vmTemplate for azurerm_virtual_desktop_host_pool resource

* hashicorp#24358: Changes as per review comments

* hashicorp#24358: Fix error

* hashicorp#24358: Adding testcase for vm_template
rizkybiz pushed a commit to rizkybiz/terraform-provider-azurerm that referenced this pull request Feb 21, 2024
@katbyte @rizkybiz
Update CHANGELOG.md hashicorp#24369
8045592
rizkybiz pushed a commit to rizkybiz/terraform-provider-azurerm that referenced this pull request Feb 29, 2024
@harshavmb @rizkybiz
hashicorp#24358: Support vm_template for azurerm_virtual_desktop_host…
b3654e2 
…_pool resource (hashicorp#24369)

* hashicorp#24358: Support vmTemplate for azurerm_virtual_desktop_host_pool resource

* hashicorp#24358: Changes as per review comments

* hashicorp#24358: Fix error

* hashicorp#24358: Adding testcase for vm_template
rizkybiz pushed a commit to rizkybiz/terraform-provider-azurerm that referenced this pull request Feb 29, 2024
@katbyte @rizkybiz
Update CHANGELOG.md hashicorp#24369
924ffad
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

@catriona-m catriona-m Awaiting requested review from catriona-m

Assignees
No one assigned
Labels
documentation service/virtual-desktops size/M
Projects
None yet
Milestone
v3.92.0
Development

Successfully merging this pull request may close these issues.

Support for vmTemplate in azurerm_virtual_desktop_host_pool
3 participants
@harshavmb @catriona-m @katbyte