Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: fix azurerm_key_vault_managed_hardware_security_module_role_assignment resource type #24365

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

wuxu92
Copy link
Contributor

@wuxu92 wuxu92 commented Jan 2, 2024

No description provided.

Copy link
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @wuxu92. Could we update the name, id and timeouts descriptions here too for consistency? Thanks!

@wuxu92
Copy link
Contributor Author

wuxu92 commented Jan 3, 2024

@catriona-m updated.

Copy link
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wuxu92 LGTM!

@catriona-m catriona-m merged commit cfd7490 into hashicorp:main Jan 3, 2024
7 checks passed
@github-actions github-actions bot added this to the v3.86.0 milestone Jan 3, 2024
Copy link

github-actions bot commented May 2, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants