Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#24134: Default logic app versions to ~4 #24280

Merged
merged 2 commits into from
Dec 20, 2023
Merged

#24134: Default logic app versions to ~4 #24280

merged 2 commits into from
Dec 20, 2023

Conversation

harshavmb
Copy link
Contributor

Default logic app versions to ~4

Fixes #24134

catriona-m
catriona-m requested changes Dec 19, 2023
View reviewed changes
Copy link
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @harshavmb thanks for submitting this. This looks good, but we should deprecate this with a 4.0 feature flag so this won't cause issues for users currently relying on the default value of ~3. This is an example of a Default value deprecation in another resource here.

@harshavmb harshavmb requested a review from catriona-m December 19, 2023 15:56
@harshavmb
Copy link
Contributor Author

Hi @catriona-m ,

Thanks for the review & I amended changes as per the review. I do see all PRs failing Pull Request Triage / triage (pull_request_target) check. I don't think it's related to my change.

@harshavmb harshavmb requested a review from catriona-m December 20, 2023 10:51
catriona-m
catriona-m approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @harshavmb LGTM!

@catriona-m catriona-m merged commit bbb16be into hashicorp:main Dec 20, 2023
23 of 24 checks passed
@github-actions github-actions bot added this to the v3.86.0 milestone Dec 20, 2023
@harshavmb harshavmb deleted the github-24134 branch December 20, 2023 13:15
@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@catriona-m catriona-m catriona-m approved these changes

Assignees
No one assigned
Labels
deprecation service/logic
Projects
None yet
Milestone
v3.86.0
Development

Successfully merging this pull request may close these issues.

azurerm_logic_app_standard default version should be ~4
2 participants
@harshavmb @catriona-m