Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_container_app_environment: add support for workload_profiles_consumption_only_enabled #24277

Closed

Conversation

jiaweitao001
Copy link
Contributor

@jiaweitao001 jiaweitao001 commented Dec 19, 2023

  • Consumption workload profile can be attached alone without a dedicated workload profile.

  • Test case passed.

=== RUN   TestAccContainerAppEnvironment_withWorkloadProfileComsumptionOnly
=== PAUSE TestAccContainerAppEnvironment_withWorkloadProfileComsumptionOnly
=== CONT  TestAccContainerAppEnvironment_withWorkloadProfileComsumptionOnly
--- PASS: TestAccContainerAppEnvironment_withWorkloadProfileComsumptionOnly (1332.53s)
PASS

resolves #24198, fix #24596

@meizenga
Copy link

When can we expect this to be merged?

@jiaweitao001 jiaweitao001 force-pushed the container_app_workload_profile branch from 9350822 to 41617f4 Compare February 19, 2024 02:07
@sdib
Copy link
Contributor

sdib commented Feb 22, 2024

would be great to have it merged, do you have any ETA ?

@kaganmersin
Copy link

@katbyte @jackofallops
Is there any improvement for this PR ? It's about adding really important key feature for Container Apps and many projects using Container Apps have been asking for this support

@jackofallops
Copy link
Member

Thanks @jiaweitao001 - As discussed offline, I'm going to close this PR in favour of folding the Consumption support into the workload_profile block directly so there are not 2 schema items attempting to control the same resource property.

Thanks again.

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.