-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azure_cognitive_deployment
- Changes model.version
property from Required
to Optional
.
#24264
Merged
+7
−7
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
7121ef5
add `source` property and update doc
liuwuliuyun 4d974bc
test optional `version` property
liuwuliuyun 4746304
test optional `version` property
liuwuliuyun 0545a36
Merge branch 'main' into cog-deployment
liuwuliuyun d5483c0
Merge branch 'main' into cog-deployment
liuwuliuyun 23c6eba
Remove `source` from the update list.
liuwuliuyun 5e9d023
Remove `source` from doc.
liuwuliuyun 5660e5d
Update website/docs/r/cognitive_deployment.html.markdown
liuwuliuyun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -66,7 +66,9 @@ A `model` block supports the following: | |
|
||
* `name` - (Required) The name of the Cognitive Services Account Deployment model. Changing this forces a new resource to be created. | ||
|
||
* `version` - (Required) The version of Cognitive Services Account Deployment model. | ||
* `source` - (Optional) Deployment model source ARM resource ID. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. what is a valid resource here? could we expand on the docs a bit more |
||
|
||
* `version` - (Optional) The version of Cognitive Services Account Deployment model. If `version` is not specified, a default version will be assigned. The default version is different for different models and might change when there is new version available for a model. | ||
liuwuliuyun marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
--- | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as this is a resource id wouldn't it make more sense to have it be