azurerm_virtual_machine_data_disk_attachment: Ignore VM applications

[jkroepke]

If a Virtual Machine has VM application configured from a different subscription, azurerm_virtual_machine_data_disk_attachment can result into a RBAC permission error, if the current SPN does not have read permissions of the VM application

The issue appears, because azurerm_virtual_machine_data_disk_attachment fully override the whole VM resource instead partially patch disk block only.

To mitigate the issue, gallery_application will be set to nil before updating the VM resource. The pattern is already used for the identity property.

% make acctests SERVICE=compute TESTARGS='-run=TestAccVirtualMachineDataDiskAttachment_virtualMachineApplication' TESTTIMEOUT='60m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/compute -run=TestAccVirtualMachineDataDiskAttachment_virtualMachineApplication -timeout 60m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccVirtualMachineDataDiskAttachment_virtualMachineApplication
=== PAUSE TestAccVirtualMachineDataDiskAttachment_virtualMachineApplication
=== CONT  TestAccVirtualMachineDataDiskAttachment_virtualMachineApplication
--- PASS: TestAccVirtualMachineDataDiskAttachment_virtualMachineApplication (757.75s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/compute       761.263s

[katbyte]

Thanks @jkroepke - LGTM 🚋

[katbyte]

checking the tests looks like we have a failure:

------- Stdout: -------
=== RUN   TestAccVirtualMachineDataDiskAttachment_virtualMachineApplication
=== PAUSE TestAccVirtualMachineDataDiskAttachment_virtualMachineApplication
=== CONT  TestAccVirtualMachineDataDiskAttachment_virtualMachineApplication
    testcase.go:113: Step 1/2 error: Error running pre-apply refresh: exit status 1
        
        Error: Missing required argument
        
          on terraform_plugin_test.tf line 115, in resource "azurerm_linux_virtual_machine" "test":
         115: resource "azurerm_linux_virtual_machine" "test" {
        
        The argument "admin_username" is required, but no definition was found.
        
        Error: Missing required argument
        
          on terraform_plugin_test.tf line 115, in resource "azurerm_linux_virtual_machine" "test":
         115: resource "azurerm_linux_virtual_machine" "test" {
        
        The argument "size" is required, but no definition was found.
        
        Error: Insufficient os_disk blocks
        
          on terraform_plugin_test.tf line 115, in resource "azurerm_linux_virtual_machine" "test":
         115: resource "azurerm_linux_virtual_machine" "test" {
        
        At least 1 "os_disk" blocks are required.
        
        Error: Unsupported argument
        
          on terraform_plugin_test.tf line 120, in resource "azurerm_linux_virtual_machine" "test":
         120:   vm_size               = "Standard_F4"
        
        An argument named "vm_size" is not expected here.
        
        Error: Unsupported argument
        
          on terraform_plugin_test.tf line 122, in resource "azurerm_linux_virtual_machine" "test":
         122:   delete_os_disk_on_termination    = true
        
        An argument named "delete_os_disk_on_termination" is not expected here.
        
        Error: Unsupported argument
        
          on terraform_plugin_test.tf line 123, in resource "azurerm_linux_virtual_machine" "test":
         123:   delete_data_disks_on_termination = true
        
        An argument named "delete_data_disks_on_termination" is not expected here.
        
        Error: Unsupported block type
        
          on terraform_plugin_test.tf line 125, in resource "azurerm_linux_virtual_machine" "test":
         125:   storage_image_reference {
        
        Blocks of type "storage_image_reference" are not expected here.
        
        Error: Unsupported block type
        
          on terraform_plugin_test.tf line 132, in resource "azurerm_linux_virtual_machine" "test":
         132:   os_profile {
        
        Blocks of type "os_profile" are not expected here.
        
        Error: Unsupported block type
        
          on terraform_plugin_test.tf line 138, in resource "azurerm_linux_virtual_machine" "test":
         138:   storage_os_disk {
        
        Blocks of type "storage_os_disk" are not expected here.
        
        Error: Unsupported block type
        
          on terraform_plugin_test.tf line 145, in resource "azurerm_linux_virtual_machine" "test":
         145:   os_profile_linux_config {
        
        Blocks of type "os_profile_linux_config" are not expected here.
--- FAIL: TestAccVirtualMachineDataDiskAttachment_virtualMachineApplication (8.47s)
FAIL

[jkroepke]

@katbyte could you check that you are on latest revision? I had the same errors before do a force-push here.

For example the error

    Error: Unsupported argument
   
     on terraform_plugin_test.tf line 123, in resource "azurerm_linux_virtual_machine" "test":
    123:   delete_data_disks_on_termination = true
   
   An argument named "delete_data_disks_on_termination" is not expected here.

Lead to an old revision, since on the whole diff, there is no delete_data_disks_on_termination.

[katbyte]

Tests pass now ! thanks LGTM 💾

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.