-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
certificate_id an optional argument of azurerm_container_app resource #24117
Conversation
…non-existing resources
…ainer_app resource
…port of non-existing resources" This reverts commit bed17a2.
This PR is being labeled as "stale" because it has not been updated for 30 or more days. If this PR is still valid, please remove the "stale" label. If this PR is blocked, please add it to the "Blocked" milestone. If you need some help completing this PR, please leave a comment letting us know. Thank you! |
I waiting for this feature to be merged to fix my terraform code ( related with issue #24110 ). |
I'd also like to see this merged asap. |
@tombuildsstuff Can this move forward? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🌵
noticed #24421 might replace this functionality so going to leave this till that PR is reviewed |
Hi @harshavmb - Thanks for this PR. This block has been deprecated due to a circular reference problem and replaced with a new resource Thanks |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This fixes #24110
Current
azurerm_container_app
resource hasingress
block which hascustom_domain
which mandatescertificate_id
to be a required field even whencertificate_binding_type
set toDisabled
by default. This contradicts with the documentation here for Azure managed certificates.This PR aims to set
certificate_id
asOptional
& only required whencertificate_binding_type
set toSniEnabled
.