#24103 : Support sku_tier argument as part of azurerm_spring_cloud_service

[harshavmb]

Support sku_tier argument as part of azurerm_spring_cloud_service resource.

Fixes #24103

[dgensert]

Hi, this looks great but we need to also provision the reference to the app-container environment if we want to create those StandardGen2 Tiers, e.g.

[katbyte]

Thanks for the pr @harshavmb - looks like we have a test failure thou:

------- Stdout: -------
=== RUN   TestAccSpringCloudService_containerRegistry
=== PAUSE TestAccSpringCloudService_containerRegistry
=== CONT  TestAccSpringCloudService_containerRegistry
    testcase.go:113: Step 1/4 error: Error running apply: exit status 1
        
        Error: creating Spring Cloud Service: (Spring Name "acctest-sc-231206075149083916" / Resource Group "acctestRG-spring-231206075149083916"): appplatform.ServicesClient#CreateOrUpdate: Failure sending request: StatusCode=400 -- Original Error: Code="BadArgument" Message="Invalid arguments: The field Name is invalid." Details=[{"code":"BadArgument","details":null,"message":"The field Name is invalid.","target":"Sku.Name"},{"code":"BadArgument","details":null,"message":"The field Tier is invalid.","target":"Sku.Tier"}]
        
          with azurerm_spring_cloud_service.test,
          on terraform_plugin_test.tf line 42, in resource "azurerm_spring_cloud_service" "test":
          42: resource "azurerm_spring_cloud_service" "test" {
        
--- FAIL: TestAccSpringCloudService_containerRegistry (132.11s)

[harshavmb]

Hi @katbyte ,

I see the reason for test failure is not setting sku_tier to Enterprise for E0. It is defaulted to Standard & the same is passed to API. The test case could be fixed by explicitly adding this argument but that would break & force the existing users to specify it for non Standard sku tiers.

I'll try to embed some logic to add it only when sku_tier is passed by end users in tandem with sku_name.

[harshavmb]

Hi @dgensert ,

Indeed it was an oversight. I'll try adding container_environment_id & setting sku_tier accordingly.

[dgensert]

looks good

[dgensert]

@katbyte anything else blocking this?

[katbyte]

Nope just delayed due to the holidays, looks good not! thanks 🧮

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.