Docs: Fix documents for document linter #24100
Conversation
| @@ -108,7 +108,7 @@ The following arguments are supported: | |||
|
|
|||
| ~> **Note:** Assigning the `virtual_network_subnet_id` property requires [RBAC permissions on the subnet](https://docs.microsoft.com/en-us/azure/app-service/overview-vnet-integration#permissions) | |||
|
|
|||
| * `webdeploy_publish_basic_authentication_enabled` - Should the default WebDeploy Basic Authentication publishing credentials enabled. Defaults to`true`. | |||
| * `webdeploy_publish_basic_authentication_enabled` - (Optional) Should the default WebDeploy Basic Authentication publishing credentials enabled. Defaults to`true`. Defaults to `true`. | |||
There was a problem hiding this comment.
there is a number of these mistakes - duplicate text
There was a problem hiding this comment.
Updated. The tool cannot handle the origin Defaults to'true' so it append another Default to mark to it... I will try to update the tool to handle this.
There was a problem hiding this comment.
Hi @wuxu92 - I had a look through this and left one more comment inline. Also it, looks like there are conflicts that need to be resolved before we can merge this. Otherwise this is looking good! Thanks!
|
Thanks for fixing this up @wuxu92 - it looks like there is a conflict now but once that is resolved this should be good to go. Thanks! |
|
@catriona-m Thanks! I have rebase the main branch and fixed the confilict and other issues just now. |
| @@ -92,7 +92,7 @@ The following arguments are supported: | |||
|
|
|||
| -> **NOTE:** Blobs with a tier of `Premium` are of account kind `StorageV2`. | |||
|
|
|||
| * `account_replication_type` - (Required) Defines the type of replication to use for this storage account. Valid options are `LRS`, `GRS`, `RAGRS`, `ZRS`, `GZRS` and `RAGZRS`. Changing this forces a new resource to be created when types `LRS`, `GRS` and `RAGRS` are changed to `ZRS`, `GZRS` or `RAGZRS` and vice versa. | |||
There was a problem hiding this comment.
Is this comment still valid? Just wanted to double check since it was recently re-added in this pr #24414
There was a problem hiding this comment.
I reversed the change. I will update the tool to accommodate this case.
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This PR is to fix some document issues since last fix. This PR will be ready to review when the Document linter CI turn on failing build when issue detected.