Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_dashboard_grafana - support for grafana_major_version property #23948

Closed
wants to merge 113 commits into from

Conversation

djryanj
Copy link
Contributor

@djryanj djryanj commented Nov 17, 2023

Added the grafana_major_version property as requested by #23666 .

Fixes #23666 .

Includes documentation update and updated acceptance tests.

Acceptance test output:

$ make acctests SERVICE='dashboard' TESTTIMEOUT='90m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/dashboard  -timeout 90m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccDashboardGrafana_basic
--- PASS: TestAccDashboardGrafana_basic (583.14s)
=== RUN   TestAccDashboardGrafana_requiresImport
--- PASS: TestAccDashboardGrafana_requiresImport (655.41s)
=== RUN   TestAccDashboardGrafana_complete
--- PASS: TestAccDashboardGrafana_complete (613.18s)
=== RUN   TestAccDashboardGrafana_update
--- PASS: TestAccDashboardGrafana_update (1175.26s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/dashboard     3027.004s

djryanj and others added 7 commits November 23, 2023 10:00
add changes requested in PR
Updated per @tombuildsstuff's suggestion in hashicorp#23948

Co-authored-by: Tom Harvey <[email protected]>
add changes requested in PR
added grafana_major_version field to all tests with
current default to deal with it being non-optional in 4.0
@djryanj
Copy link
Contributor Author

djryanj commented Nov 23, 2023

I messed up this PR; will re-open a new one.

Copy link

github-actions bot commented May 6, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.