-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_dashboard_grafana - support for grafana_major_version property #23948
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add changes requested in PR
Updated per @tombuildsstuff's suggestion in hashicorp#23948 Co-authored-by: Tom Harvey <[email protected]>
add changes requested in PR
added grafana_major_version field to all tests with current default to deal with it being non-optional in 4.0
github-actions
bot
added
dependencies
service/mssql
Microsoft SQL Server
service/app-service
service/event-hubs
EventHubs
service/cosmosdb
service/monitor
service/redis
service/devtestlabs
service/firewall
service/security-center
service/spring
service/azure-stack-hci
service/network
state-migration
service/service-networking
size/XL
and removed
size/M
labels
Nov 23, 2023
I messed up this PR; will re-open a new one. |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
dependencies
documentation
service/app-service
service/azure-stack-hci
service/cosmosdb
service/dashboard
service/devtestlabs
service/event-hubs
EventHubs
service/firewall
service/monitor
service/mssql
Microsoft SQL Server
service/network
service/redis
service/security-center
service/service-networking
service/spring
size/XL
state-migration
waiting-response
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the
grafana_major_version
property as requested by #23666 .Fixes #23666 .
Includes documentation update and updated acceptance tests.
Acceptance test output: