Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appservice - support disabling access for default basic auth #23900

Merged
merged 10 commits into from
Nov 16, 2023

Conversation

jackofallops
Copy link
Member

  • azurerm_linux_function_app - add support for disabling Basic Auth for default Publishing Profile via new properties ftp_publish_basic_authentication_enabled and webdeploy_publish_basic_authentication_enabled
  • azurerm_linux_function_app_slot - add support for disabling Basic Auth for default Publishing Profile via new properties ftp_publish_basic_authentication_enabled and webdeploy_publish_basic_authentication_enabled
  • azurerm_linux_web_app - add support for disabling Basic Auth for default Publishing Profile via new properties ftp_publish_basic_authentication_enabled and webdeploy_publish_basic_authentication_enabled
  • azurerm_linux_web_app_slot - add support for disabling Basic Auth for default Publishing Profile via new properties ftp_publish_basic_authentication_enabled and webdeploy_publish_basic_authentication_enabled
  • azurerm_windows_function_app - add support for disabling Basic Auth for default Publishing Profile via new properties ftp_publish_basic_authentication_enabled and webdeploy_publish_basic_authentication_enabled
  • azurerm_windows_function_app_slot - add support for disabling Basic Auth for default Publishing Profile via new properties ftp_publish_basic_authentication_enabled and webdeploy_publish_basic_authentication_enabled
  • azurerm_windows_web_app - add support for disabling Basic Auth for default Publishing Profile via new properties ftp_publish_basic_authentication_enabled and webdeploy_publish_basic_authentication_enabled
  • azurerm_windows_web_app_slot - add support for disabling Basic Auth for default Publishing Profile via new properties ftp_publish_basic_authentication_enabled and webdeploy_publish_basic_authentication_enabled

closes #9290

Copy link
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of minor comments about log messages that appear in most of the files, but otherwise LGTM!

@jackofallops jackofallops merged commit 36ed027 into main Nov 16, 2023
22 checks passed
@jackofallops jackofallops deleted the f/app-service-support-disable-publish-profile branch November 16, 2023 12:51
@github-actions github-actions bot added this to the v3.81.0 milestone Nov 16, 2023
jackofallops added a commit that referenced this pull request Nov 16, 2023
dduportal pushed a commit to jenkins-infra/azure that referenced this pull request Nov 17, 2023
<Actions>
<action
id="f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8">
        <h3>Bump Terraform `azurerm` provider version</h3>
<details
id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24">
            <summary>Update Terraform lock file</summary>
<p>&#34;hashicorp/azurerm&#34; updated from &#34;3.80.0&#34; to
&#34;3.81.0&#34; in file &#34;.terraform.lock.hcl&#34;</p>
            <details>
                <summary>3.81.0</summary>
<pre>Changelog retrieved
from:&#xA;&#x9;https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.81.0&#xA;ENHANCEMENTS:&#xA;&#xA;*
dependencies: updating to `v0.20231116.1162710` of
`github.com/hashicorp/go-azure-sdk`
([#23922](hashicorp/terraform-provider-azurerm#23922
`managedservices`: updating to use the base layer from
`hashicorp/go-azure-sdk` rather than `Azure/go-autorest`
([#23890](hashicorp/terraform-provider-azurerm#23890
`network`: updating to API Version `2023-06-01`
([#23875](hashicorp/terraform-provider-azurerm#23875
`servicelinker`: updating to use the base layer from
`hashicorp/go-azure-sdk` rather than `Azure/go-autorest`
([#23890](hashicorp/terraform-provider-azurerm#23890
`storage`: refactoring usages of `github.com/hashicorp/go-azure-sdk` to
use the base layer from `hashicorp/go-azure-sdk` rather than
`Azure/go-autorest`
([#23890](hashicorp/terraform-provider-azurerm#23890
Data Source: `azurerm_network_ddos_protection_plan`: refactoring to use
`hashicorp/go-azure-sdk`
([#23849](hashicorp/terraform-provider-azurerm#23849
`azurerm_linux_function_app` - add support for disabling Basic Auth for
default Publishing Profile via new properties
`ftp_publish_basic_authentication_enabled` and
`webdeploy_publish_basic_authentication_enabled`
([#23900](hashicorp/terraform-provider-azurerm#23900
`azurerm_linux_function_app_slot` - add support for disabling Basic Auth
for default Publishing Profile via new properties
`ftp_publish_basic_authentication_enabled` and
`webdeploy_publish_basic_authentication_enabled`
([#23900](hashicorp/terraform-provider-azurerm#23900
`azurerm_linux_web_app` - add support for disabling Basic Auth for
default Publishing Profile via new properties
`ftp_publish_basic_authentication_enabled` and
`webdeploy_publish_basic_authentication_enabled`
([#23900](hashicorp/terraform-provider-azurerm#23900
`azurerm_linux_web_app_slot` - add support for disabling Basic Auth for
default Publishing Profile via new properties
`ftp_publish_basic_authentication_enabled` and
`webdeploy_publish_basic_authentication_enabled`
([#23900](hashicorp/terraform-provider-azurerm#23900
`azurerm_logic_app_integration_account_certificate` - `name` now accepts
underscores
([#23866](hashicorp/terraform-provider-azurerm#23866
`azurerm_logic_app_integration_account_partner` -
`business_identity.value` now accepts underscores
([#23866](hashicorp/terraform-provider-azurerm#23866
`azurerm_monitor_data_collection_rule` - added support for
`WorkspaceTransforms` as `kind`
([#23873](hashicorp/terraform-provider-azurerm#23873
`azurerm_network_ddos_protection_plan`: refactoring to use
`hashicorp/go-azure-sdk`
([#23849](hashicorp/terraform-provider-azurerm#23849
`azurerm_windows_function_app` - add support for disabling Basic Auth
for default Publishing Profile via new properties
`ftp_publish_basic_authentication_enabled` and
`webdeploy_publish_basic_authentication_enabled`
([#23900](hashicorp/terraform-provider-azurerm#23900
`azurerm_windows_function_app_slot` - add support for disabling Basic
Auth for default Publishing Profile via new properties
`ftp_publish_basic_authentication_enabled` and
`webdeploy_publish_basic_authentication_enabled`
([#23900](hashicorp/terraform-provider-azurerm#23900
`azurerm_windows_web_app` - add support for disabling Basic Auth for
default Publishing Profile via new properties
`ftp_publish_basic_authentication_enabled` and
`webdeploy_publish_basic_authentication_enabled`
([#23900](hashicorp/terraform-provider-azurerm#23900
`azurerm_windows_web_app_slot` - add support for disabling Basic Auth
for default Publishing Profile via new properties
`ftp_publish_basic_authentication_enabled` and
`webdeploy_publish_basic_authentication_enabled`
([#23900](https://github.com/hashicorp/terraform-provider-azurerm/issues/23900))&#xA;&#xA;&#xA;</pre>
            </details>
        </details>
    </action>
</Actions>

---

<table>
  <tr>
    <td width="77">
<img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli
logo" width="50" height="50">
    </td>
    <td>
      <p>
Created automatically by <a
href="https://www.updatecli.io/">Updatecli</a>
      </p>
      <details><summary>Options:</summary>
        <br />
<p>Most of Updatecli configuration is done via <a
href="https://www.updatecli.io/docs/prologue/quick-start/">its
manifest(s)</a>.</p>
        <ul>
<li>If you close this pull request, Updatecli will automatically reopen
it, the next time it runs.</li>
<li>If you close this pull request and delete the base branch, Updatecli
will automatically recreate it, erasing all previous commits made.</li>
        </ul>
        <p>
Feel free to report any issues at <a
href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br
/>
If you find this tool useful, do not hesitate to star <a
href="https://github.com/updatecli/updatecli/stargazers">our GitHub
repository</a> as a sign of appreciation, and/or to tell us directly on
our <a
href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>!
        </p>
      </details>
    </td>
  </tr>
</table>

Co-authored-by: Jenkins Infra Bot (updatecli) <[email protected]>
@artagame21
Copy link

Hi saw that this option is not included in standard logic apps. Can you maybe suggest an option on how we can do it using terraform? Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for disabling basic auth access to the SCM site
3 participants