-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
appservice
- support disabling access for default basic auth
#23900
appservice
- support disabling access for default basic auth
#23900
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of minor comments about log messages that appear in most of the files, but otherwise LGTM!
<Actions> <action id="f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8"> <h3>Bump Terraform `azurerm` provider version</h3> <details id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24"> <summary>Update Terraform lock file</summary> <p>"hashicorp/azurerm" updated from "3.80.0" to "3.81.0" in file ".terraform.lock.hcl"</p> <details> <summary>3.81.0</summary> <pre>Changelog retrieved from:
	https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.81.0
ENHANCEMENTS:

* dependencies: updating to `v0.20231116.1162710` of `github.com/hashicorp/go-azure-sdk` ([#23922](hashicorp/terraform-provider-azurerm#23922 `managedservices`: updating to use the base layer from `hashicorp/go-azure-sdk` rather than `Azure/go-autorest` ([#23890](hashicorp/terraform-provider-azurerm#23890 `network`: updating to API Version `2023-06-01` ([#23875](hashicorp/terraform-provider-azurerm#23875 `servicelinker`: updating to use the base layer from `hashicorp/go-azure-sdk` rather than `Azure/go-autorest` ([#23890](hashicorp/terraform-provider-azurerm#23890 `storage`: refactoring usages of `github.com/hashicorp/go-azure-sdk` to use the base layer from `hashicorp/go-azure-sdk` rather than `Azure/go-autorest` ([#23890](hashicorp/terraform-provider-azurerm#23890 Data Source: `azurerm_network_ddos_protection_plan`: refactoring to use `hashicorp/go-azure-sdk` ([#23849](hashicorp/terraform-provider-azurerm#23849 `azurerm_linux_function_app` - add support for disabling Basic Auth for default Publishing Profile via new properties `ftp_publish_basic_authentication_enabled` and `webdeploy_publish_basic_authentication_enabled` ([#23900](hashicorp/terraform-provider-azurerm#23900 `azurerm_linux_function_app_slot` - add support for disabling Basic Auth for default Publishing Profile via new properties `ftp_publish_basic_authentication_enabled` and `webdeploy_publish_basic_authentication_enabled` ([#23900](hashicorp/terraform-provider-azurerm#23900 `azurerm_linux_web_app` - add support for disabling Basic Auth for default Publishing Profile via new properties `ftp_publish_basic_authentication_enabled` and `webdeploy_publish_basic_authentication_enabled` ([#23900](hashicorp/terraform-provider-azurerm#23900 `azurerm_linux_web_app_slot` - add support for disabling Basic Auth for default Publishing Profile via new properties `ftp_publish_basic_authentication_enabled` and `webdeploy_publish_basic_authentication_enabled` ([#23900](hashicorp/terraform-provider-azurerm#23900 `azurerm_logic_app_integration_account_certificate` - `name` now accepts underscores ([#23866](hashicorp/terraform-provider-azurerm#23866 `azurerm_logic_app_integration_account_partner` - `business_identity.value` now accepts underscores ([#23866](hashicorp/terraform-provider-azurerm#23866 `azurerm_monitor_data_collection_rule` - added support for `WorkspaceTransforms` as `kind` ([#23873](hashicorp/terraform-provider-azurerm#23873 `azurerm_network_ddos_protection_plan`: refactoring to use `hashicorp/go-azure-sdk` ([#23849](hashicorp/terraform-provider-azurerm#23849 `azurerm_windows_function_app` - add support for disabling Basic Auth for default Publishing Profile via new properties `ftp_publish_basic_authentication_enabled` and `webdeploy_publish_basic_authentication_enabled` ([#23900](hashicorp/terraform-provider-azurerm#23900 `azurerm_windows_function_app_slot` - add support for disabling Basic Auth for default Publishing Profile via new properties `ftp_publish_basic_authentication_enabled` and `webdeploy_publish_basic_authentication_enabled` ([#23900](hashicorp/terraform-provider-azurerm#23900 `azurerm_windows_web_app` - add support for disabling Basic Auth for default Publishing Profile via new properties `ftp_publish_basic_authentication_enabled` and `webdeploy_publish_basic_authentication_enabled` ([#23900](hashicorp/terraform-provider-azurerm#23900 `azurerm_windows_web_app_slot` - add support for disabling Basic Auth for default Publishing Profile via new properties `ftp_publish_basic_authentication_enabled` and `webdeploy_publish_basic_authentication_enabled` ([#23900](https://github.com/hashicorp/terraform-provider-azurerm/issues/23900))


</pre> </details> </details> </action> </Actions> --- <table> <tr> <td width="77"> <img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli logo" width="50" height="50"> </td> <td> <p> Created automatically by <a href="https://www.updatecli.io/">Updatecli</a> </p> <details><summary>Options:</summary> <br /> <p>Most of Updatecli configuration is done via <a href="https://www.updatecli.io/docs/prologue/quick-start/">its manifest(s)</a>.</p> <ul> <li>If you close this pull request, Updatecli will automatically reopen it, the next time it runs.</li> <li>If you close this pull request and delete the base branch, Updatecli will automatically recreate it, erasing all previous commits made.</li> </ul> <p> Feel free to report any issues at <a href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br /> If you find this tool useful, do not hesitate to star <a href="https://github.com/updatecli/updatecli/stargazers">our GitHub repository</a> as a sign of appreciation, and/or to tell us directly on our <a href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>! </p> </details> </td> </tr> </table> Co-authored-by: Jenkins Infra Bot (updatecli) <[email protected]>
Hi saw that this option is not included in standard logic apps. Can you maybe suggest an option on how we can do it using terraform? Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
azurerm_linux_function_app
- add support for disabling Basic Auth for default Publishing Profile via new propertiesftp_publish_basic_authentication_enabled
andwebdeploy_publish_basic_authentication_enabled
azurerm_linux_function_app_slot
- add support for disabling Basic Auth for default Publishing Profile via new propertiesftp_publish_basic_authentication_enabled
andwebdeploy_publish_basic_authentication_enabled
azurerm_linux_web_app
- add support for disabling Basic Auth for default Publishing Profile via new propertiesftp_publish_basic_authentication_enabled
andwebdeploy_publish_basic_authentication_enabled
azurerm_linux_web_app_slot
- add support for disabling Basic Auth for default Publishing Profile via new propertiesftp_publish_basic_authentication_enabled
andwebdeploy_publish_basic_authentication_enabled
azurerm_windows_function_app
- add support for disabling Basic Auth for default Publishing Profile via new propertiesftp_publish_basic_authentication_enabled
andwebdeploy_publish_basic_authentication_enabled
azurerm_windows_function_app_slot
- add support for disabling Basic Auth for default Publishing Profile via new propertiesftp_publish_basic_authentication_enabled
andwebdeploy_publish_basic_authentication_enabled
azurerm_windows_web_app
- add support for disabling Basic Auth for default Publishing Profile via new propertiesftp_publish_basic_authentication_enabled
andwebdeploy_publish_basic_authentication_enabled
azurerm_windows_web_app_slot
- add support for disabling Basic Auth for default Publishing Profile via new propertiesftp_publish_basic_authentication_enabled
andwebdeploy_publish_basic_authentication_enabled
closes #9290