DiffSuppressFunc to ignore azurerm_virtual_network.address_space reordering #23793
Conversation
…fect and is not updated by Azure if the element vals are not changing
There was a problem hiding this comment.
Hi @tiwood
Thanks for this PR. Unfortunately a type change from a List to a Set is considered a breaking change in the schema, and given the importance and prevalence of use of this resource we're reluctant to do so to avoid breaking users configurations (for example, this would require changes to any interpolations of this field value). We understand the frustration of the diff, but this will need to be addressed in another way. I can suggest trying a CustomiseDiff which could normalise the order of this list for the old/new comparison and flag correct diffs appropriately. Is this something you can look into?
Alternatively, we can possibly reconsider this for a major version where we are better able to communicate and accept breaking changes
Thanks
tiwood
changed the title
|
Hi @jackofallops |
|
Hi @jackofallops |
|
@jackofallops, @magodo, @tombuildsstuff Sorry for the random mention, I was wondering if this can be reviewed soon? |
|
@katbyte maybe you can help reviewing this? |
|
@jackofallops friendly ping |
|
@stephybun, merging this PR is no longer a breaking change, as I've changed the implementation according to the requested changes. I really would appreciate a review. (ping @tombuildsstuff) |
<Actions>
<action
id="f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8">
<h3>Bump Terraform `azurerm` provider version</h3>
<details
id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24">
<summary>Update Terraform lock file</summary>
<p>changes detected:
	"hashicorp/azurerm" updated from
"3.100.0" to "3.101.0" in file
".terraform.lock.hcl"</p>
<details>
<summary>3.101.0</summary>
<pre>Changelog retrieved
from:
	https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.101.0
ENHANCEMENTS:

*
dependencies: updating to `v0.20240424.1114424` of
`github.com/hashicorp/go-azure-sdk`
([#25749](hashicorp/terraform-provider-azurerm#25749
dependencies: updating to `v0.27.0` of
`github.com/tombuildsstuff/giovanni`
([#25702](hashicorp/terraform-provider-azurerm#25702
dependencies: updating `golang.org/x/net` to `0.23.0`
*
`azurerm_cognitive_account` - the `kind` property now supports
`ConversationalLanguageUnderstanding`
([#25735](hashicorp/terraform-provider-azurerm#25735
`azurerm_container_app_custom_domain` - support the ability to use Azure
Managed Certificates
([#25356](https://github.com/hashicorp/terraform-provider-azurerm/issues/25356))

BUG
FIXES:

* Data Source: `azurerm_application_insights` - set
correct AppID in data source
([#25687](hashicorp/terraform-provider-azurerm#25687
`azurerm_virtual_network` - suppress diff in ordering for
`address_space` due to inconsistent API response
([#23793](hashicorp/terraform-provider-azurerm#23793
`azurerm_storage_data_lake_gen2_filesystem` - add context deadline for
import
([#25712](hashicorp/terraform-provider-azurerm#25712
`azurerm_virtual_network_gateway` - preserve existing `nat_rules` on
updates
([#25690](https://github.com/hashicorp/terraform-provider-azurerm/issues/25690))


</pre>
</details>
</details>
<a
href="https://infra.ci.jenkins.io/job/updatecli/job/azure/job/main/135/">Jenkins
pipeline link</a>
</action>
</Actions>
---
<table>
<tr>
<td width="77">
<img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli
logo" width="50" height="50">
</td>
<td>
<p>
Created automatically by <a
href="https://www.updatecli.io/">Updatecli</a>
</p>
<details><summary>Options:</summary>
<br />
<p>Most of Updatecli configuration is done via <a
href="https://www.updatecli.io/docs/prologue/quick-start/">its
manifest(s)</a>.</p>
<ul>
<li>If you close this pull request, Updatecli will automatically reopen
it, the next time it runs.</li>
<li>If you close this pull request and delete the base branch, Updatecli
will automatically recreate it, erasing all previous commits made.</li>
</ul>
<p>
Feel free to report any issues at <a
href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br
/>
If you find this tool useful, do not hesitate to star <a
href="https://github.com/updatecli/updatecli/stargazers">our GitHub
repository</a> as a sign of appreciation, and/or to tell us directly on
our <a
href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>!
</p>
</details>
</td>
</tr>
</table>
Co-authored-by: Jenkins Infra Bot (updatecli) <[email protected]>
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This changes
azurerm_virtual_network.address_spacefrom TypeList to TypeSet, becauseFixes #23328