New Resource: `azurerm_dev_center_gallery` #23760

jiaweitao001 · 2023-11-02T09:10:28Z

Generated by Pandora code gen tool.
All acc tests passed.

=== RUN   TestAccDevCenterGallery_basic
=== PAUSE TestAccDevCenterGallery_basic
=== RUN   TestAccDevCenterGallery_requiresImport
=== PAUSE TestAccDevCenterGallery_requiresImport
=== RUN   TestAccDevCenterGallery_complete
=== PAUSE TestAccDevCenterGallery_complete
=== RUN   TestAccDevCenterGallery_update
=== PAUSE TestAccDevCenterGallery_update
=== CONT  TestAccDevCenterGallery_basic
=== CONT  TestAccDevCenterGallery_complete
=== CONT  TestAccDevCenterGallery_update
=== CONT  TestAccDevCenterGallery_requiresImport
--- PASS: TestAccDevCenterGallery_update (1137.43s)
--- PASS: TestAccDevCenterGallery_basic (1231.93s)
--- PASS: TestAccDevCenterGallery_complete (1424.79s)
--- PASS: TestAccDevCenterGallery_requiresImport (1471.54s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/devcenter     1488.768s

stephybun

@jiaweitao001 - I'm unsure if this PR was opened so that we can see the output of the generated resource from Pandora, but just to clarify:

pandora generated resources are added to the azurerm repo by an automatically generated PR, they are not manually opened PRs with the resource output copied into it

Please close this PR, review will continue in hashicorp/pandora#3271

stephybun · 2024-02-06T08:02:02Z

Re-opening since the test requirements for this resource cannot be covered by Pandora at this point in time

stephybun

Thanks @jiaweitao001, the tests look good! Just need to rename the gallery_resource_id property (don't forget to update it in the tests and docs) and then this should be good to go!

stephybun · 2024-02-06T08:03:11Z

internal/services/devcenter/dev_center_gallery_resource_gen.go

+
+type DevCenterGalleryResourceSchema struct {
+	DevCenterId       string `tfschema:"dev_center_id"`
+	GalleryResourceId string `tfschema:"gallery_resource_id"`


Like we did for the generated resource let's rename this to shared_gallery_id

Suggested change

GalleryResourceId string `tfschema:"gallery_resource_id"`

GalleryResourceId string `tfschema:"shared_gallery_id"`

stephybun · 2024-02-06T08:07:58Z

internal/services/devcenter/dev_center_gallery_resource_gen.go

+			Required: true,
+			Type:     pluginsdk.TypeString,
+		},
+		"gallery_resource_id": {


Suggested change

"gallery_resource_id": {

"shared_gallery_id": {

stephybun

Thanks @jiaweitao001 LGTM 👍

tombuildsstuff · 2024-02-07T12:37:26Z

@jiaweitao001 FYI the generated files shouldn't be added by hand - the automation regenerates these based on the files within the Pandora repository - so if these aren't defined there they'll be removed by the automation when it next runs, as is happening here - as such we need to add the definition for this Resource, so this doesn't get removed.

jiaweitao001 · 2024-02-08T01:34:10Z

@jiaweitao001 FYI the generated files shouldn't be added by hand - the automation regenerates these based on the files within the Pandora repository - so if these aren't defined there they'll be removed by the automation when it next runs, as is happening here - as such we need to add the definition for this Resource, so this doesn't get removed.

Hi @tombuildsstuff , thanks for the reminder. This resource was added manually because we had trouble on generating the code with Pandora code gen tool. I'm wondering if we add a definition for the resource in Pandora, is the auto gen tool gonna skip this resource or overwrite it?

tombuildsstuff · 2024-02-08T10:01:24Z

@jiaweitao001 forgot to circle back here after fixing this yesterday - apologies.

Reading the context in the other threads I ended up opening #24806 to rename these files so these are no longer generated - which'll fix this in a different manner.

<Actions> <action id="f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8"> <h3>Bump Terraform `azurerm` provider version</h3> <details id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24"> <summary>Update Terraform lock file</summary> <p>changes detected:
	"hashicorp/azurerm" updated from "3.90.0" to "3.91.0" in file ".terraform.lock.hcl"</p> <details> <summary>3.91.0</summary> <pre>Changelog retrieved from:
	https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.91.0
FEATURES:

* **New Data Source**: `azurerm_databricks_access_connector` ([#24769](hashicorp/terraform-provider-azurerm#24769 **New Resource**: `azurerm_data_protection_backup_policy_kubernetes_cluster` ([#24718](hashicorp/terraform-provider-azurerm#24718 **New Resource**: `azurerm_chaos_studio_experiment` ([#24779](hashicorp/terraform-provider-azurerm#24779 **New Resource**: `azurerm_chaos_studio_capability` ([#24779](hashicorp/terraform-provider-azurerm#24779 **New Resource**: `azurerm_dev_center_gallery` ([#23760](hashicorp/terraform-provider-azurerm#23760 **New Resource:** `azurerm_kubernetes_fleet_member` ([#24792](hashicorp/terraform-provider-azurerm#24792 **New Resource:** `azurerm_iotcentral_organization` ([#23132](hashicorp/terraform-provider-azurerm#23132 **New Resource:** `azurerm_spring_cloud_app_dynamics_application_performance_monitoring` ([#24750](https://github.com/hashicorp/terraform-provider-azurerm/issues/24750))

ENHANCEMENTS:

* dependencies: updating to `v0.20240208.1095436` of `github.com/hashicorp/go-azure-sdk/resource-manager` ([#24819](hashicorp/terraform-provider-azurerm#24819 dependencies: updating to `v0.20240208.1095436` of `github.com/hashicorp/go-azure-sdk/sdk` ([#24819](hashicorp/terraform-provider-azurerm#24819 dependencies: refactor `azurerm_app_service_environment_v3` to use `go-azure-sdk` ([#24760](hashicorp/terraform-provider-azurerm#24760 dependencies: refactor `azurerm_role_definition` to use `go-azure-sdk` ([#24266](hashicorp/terraform-provider-azurerm#24266 `managedhsm`: updating to use the transport layer from `hashicorp/go-azure-sdk` rather than `Azure/go-autorest` ([#24761](hashicorp/terraform-provider-azurerm#24761 `hdinsight`: updating to API Version `2023-07-01` ([#24761](hashicorp/terraform-provider-azurerm#24761 `streamanalytics`: updating to use the transport layer from `hashicorp/go-azure-sdk` rather than `Azure/go-autorest` ([#24819](hashicorp/terraform-provider-azurerm#24819 `azurerm_app_service_environment_v3` - support for the `remote_debugging_enabled` property ([#24760](hashicorp/terraform-provider-azurerm#24760 `azurerm_storage_account` - support for the `local_user_enabled` property ([#24800](hashicorp/terraform-provider-azurerm#24800 `azurerm_log_analytics_workspace_table` - support for the `total_retention_in_days` property ([#24513](hashicorp/terraform-provider-azurerm#24513 `azurerm_maching_learning_workspace` - support for the `feature_store` and `kind` properties ([#24716](hashicorp/terraform-provider-azurerm#24716 `azurerm_traffic_manager_azure_endpoint` - support for the `always_serve_enabled` property ([#24573](hashicorp/terraform-provider-azurerm#24573 `azurerm_traffic_manager_external_endpoint` - support for the `always_serve_enabled` property ([#24573](https://github.com/hashicorp/terraform-provider-azurerm/issues/24573))

BUG FIXES:

* `azurerm_api_management` - the `virtual_network_configuration` property now updates correctly outside of `virtual_network_type` ([#24569](https://github.com/hashicorp/terraform-provider-azurerm/issues/24569))


</pre> </details> </details> <a href="https://infra.ci.jenkins.io/job/terraform-jobs/job/azure/job/main/1083/">Jenkins pipeline link</a> </action> </Actions> --- <table> <tr> <td width="77"> <img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli logo" width="50" height="50"> </td> <td> <p> Created automatically by <a href="https://www.updatecli.io/">Updatecli</a> </p> <details><summary>Options:</summary> <br /> <p>Most of Updatecli configuration is done via <a href="https://www.updatecli.io/docs/prologue/quick-start/">its manifest(s)</a>.</p> <ul> <li>If you close this pull request, Updatecli will automatically reopen it, the next time it runs.</li> <li>If you close this pull request and delete the base branch, Updatecli will automatically recreate it, erasing all previous commits made.</li> </ul> <p> Feel free to report any issues at <a href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br /> If you find this tool useful, do not hesitate to star <a href="https://github.com/updatecli/updatecli/stargazers">our GitHub repository</a> as a sign of appreciation, and/or to tell us directly on our <a href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>! </p> </details> </td> </tr> </table> Co-authored-by: Jenkins Infra Bot (updatecli) <[email protected]>

github-actions · 2024-04-25T02:07:48Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

New Resource: azurerm_dev_center_gallery

a87b1ac

github-actions bot added documentation service/dev-center size/XL labels Nov 2, 2023

stephybun reviewed Nov 2, 2023

View reviewed changes

github-actions bot added the waiting-response label Nov 2, 2023

jiaweitao001 closed this Nov 13, 2023

stephybun reopened this Feb 6, 2024

stephybun mentioned this pull request Feb 6, 2024

Preparation for devcenter gallery resource generation hashicorp/pandora#3271

Closed

stephybun requested changes Feb 6, 2024

View reviewed changes

rename shared gallery id

f9f5351

github-actions bot removed the waiting-response label Feb 6, 2024

stephybun approved these changes Feb 6, 2024

View reviewed changes

stephybun added the new-resource label Feb 6, 2024

stephybun merged commit 7f840d7 into hashicorp:main Feb 6, 2024
34 checks passed

github-actions bot added this to the v3.91.0 milestone Feb 6, 2024

stephybun added a commit that referenced this pull request Feb 6, 2024

Update for #23760

c285b2c

github-actions bot locked as resolved and limited conversation to collaborators Apr 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Resource: `azurerm_dev_center_gallery` #23760

New Resource: `azurerm_dev_center_gallery` #23760

jiaweitao001 commented Nov 2, 2023

stephybun left a comment

stephybun commented Feb 6, 2024

stephybun left a comment •

edited

Loading

stephybun Feb 6, 2024

stephybun Feb 6, 2024

jiaweitao001 Feb 6, 2024

stephybun left a comment

tombuildsstuff commented Feb 7, 2024

jiaweitao001 commented Feb 8, 2024

tombuildsstuff commented Feb 8, 2024

github-actions bot commented Apr 25, 2024

	GalleryResourceId string `tfschema:"gallery_resource_id"`
	GalleryResourceId string `tfschema:"shared_gallery_id"`

New Resource: azurerm_dev_center_gallery #23760

New Resource: azurerm_dev_center_gallery #23760

Conversation

jiaweitao001 commented Nov 2, 2023

stephybun left a comment

Choose a reason for hiding this comment

stephybun commented Feb 6, 2024

stephybun left a comment • edited Loading

Choose a reason for hiding this comment

stephybun Feb 6, 2024

Choose a reason for hiding this comment

stephybun Feb 6, 2024

Choose a reason for hiding this comment

jiaweitao001 Feb 6, 2024

Choose a reason for hiding this comment

stephybun left a comment

Choose a reason for hiding this comment

tombuildsstuff commented Feb 7, 2024

jiaweitao001 commented Feb 8, 2024

tombuildsstuff commented Feb 8, 2024

github-actions bot commented Apr 25, 2024

New Resource: `azurerm_dev_center_gallery` #23760

New Resource: `azurerm_dev_center_gallery` #23760

stephybun left a comment •

edited

Loading