Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_spring_cloud_customized_accelerator - use pandora sdk #23756

Merged
merged 3 commits into from
Nov 7, 2023
Merged

azurerm_spring_cloud_customized_accelerator - use pandora sdk #23756

merged 3 commits into from
Nov 7, 2023

Conversation

ms-henglu
Copy link
Contributor

This PR switches to Pandora SDK for azurerm_spring_cloud_customized_accelerator resource.

@ms-henglu ms-henglu marked this pull request as draft November 2, 2023 02:10
magodo
magodo requested changes Nov 3, 2023
View reviewed changes
Copy link
Collaborator

@magodo magodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!
I've taken a look through and left some comments inline, but this is mostly looking good to me 👍

internal/services/springcloud/spring_cloud_customized_accelerator_resource.go Outdated Show resolved Hide resolved
internal/services/springcloud/spring_cloud_customized_accelerator_resource.go Outdated Show resolved Hide resolved
internal/services/springcloud/spring_cloud_customized_accelerator_resource.go Show resolved Hide resolved
internal/services/springcloud/spring_cloud_customized_accelerator_resource.go Show resolved Hide resolved
@magodo magodo marked this pull request as ready for review November 3, 2023 09:38
katbyte
katbyte approved these changes Nov 7, 2023
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌴

@katbyte katbyte merged commit e22e88a into hashicorp:main Nov 7, 2023
21 checks passed
@github-actions github-actions bot added this to the v3.80.0 milestone Nov 7, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@magodo magodo magodo requested changes

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
service/spring size/L
Projects
None yet
Milestone
v3.80.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ms-henglu @katbyte @magodo