add length check to avoid panic #23740
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issue: #23739 |
1 task
stephybun
requested changes
Nov 1, 2023
There was a problem hiding this comment.
Thanks for this PR @calebak404.
There are some compilation failures showing up in the GitHub Actions - if you can fix those up we can take another look at this.
add length check to match linux_web_app to avoid potential panic in windows_web_app linux change done in hashicorp#21328
|
Hi, are there any other changes I should be making to ensure this is a successful PR? |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add length check to match linux_web_app to avoid potential panic in windows_web_app
linux change done in #21328