Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standardized validation function signitures #2372

Merged
merged 1 commit into from
Nov 22, 2018
Merged

standardized validation function signitures #2372

merged 1 commit into from
Nov 22, 2018

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Nov 21, 2018

Makes it a little more clear what each return value is, I know this confused me when I started.

@katbyte katbyte added this to the 1.20.0 milestone Nov 21, 2018
@katbyte katbyte requested a review from a team November 21, 2018 20:31
@ghost ghost added the size/XL label Nov 21, 2018
@katbyte katbyte changed the title standardized validation function sigs standardized validation function signitures Nov 21, 2018
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@katbyte katbyte merged commit 22ca098 into master Nov 22, 2018
@katbyte katbyte deleted the validation-sig branch November 22, 2018 08:05
@ghost
Copy link

ghost commented Mar 5, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants