-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new resource:azurerm_application_load_balancer_subnet_association
#23628
Changes from 8 commits
31e8553
1a1cdfd
5674fea
3407b4e
4d8b3c3
a6ee143
ab9fb63
41d261e
6db2907
24ff0e0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|
@@ -0,0 +1,214 @@ | ||||||||||||
package servicenetworking | ||||||||||||
|
||||||||||||
import ( | ||||||||||||
"context" | ||||||||||||
"fmt" | ||||||||||||
"time" | ||||||||||||
|
||||||||||||
"github.com/hashicorp/go-azure-helpers/lang/response" | ||||||||||||
"github.com/hashicorp/go-azure-helpers/resourcemanager/commonids" | ||||||||||||
"github.com/hashicorp/go-azure-helpers/resourcemanager/commonschema" | ||||||||||||
"github.com/hashicorp/go-azure-helpers/resourcemanager/location" | ||||||||||||
"github.com/hashicorp/go-azure-helpers/resourcemanager/tags" | ||||||||||||
"github.com/hashicorp/go-azure-sdk/resource-manager/servicenetworking/2023-05-01-preview/associationsinterface" | ||||||||||||
"github.com/hashicorp/go-azure-sdk/resource-manager/servicenetworking/2023-05-01-preview/trafficcontrollerinterface" | ||||||||||||
"github.com/hashicorp/terraform-provider-azurerm/internal/sdk" | ||||||||||||
"github.com/hashicorp/terraform-provider-azurerm/internal/services/servicenetworking/validate" | ||||||||||||
"github.com/hashicorp/terraform-provider-azurerm/internal/tf/pluginsdk" | ||||||||||||
) | ||||||||||||
|
||||||||||||
type ApplicationLoadBalancerAssociationResource struct{} | ||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. as do all these types?
Suggested change
|
||||||||||||
|
||||||||||||
type AssociationResourceModel struct { | ||||||||||||
Name string `tfschema:"name"` | ||||||||||||
ApplicationLoadBalancerId string `tfschema:"application_load_balancer_id"` | ||||||||||||
SubnetId string `tfschema:"subnet_id"` | ||||||||||||
Tags map[string]interface{} `tfschema:"tags"` | ||||||||||||
} | ||||||||||||
|
||||||||||||
var _ sdk.ResourceWithUpdate = ApplicationLoadBalancerAssociationResource{} | ||||||||||||
|
||||||||||||
func (t ApplicationLoadBalancerAssociationResource) Arguments() map[string]*pluginsdk.Schema { | ||||||||||||
return map[string]*pluginsdk.Schema{ | ||||||||||||
"name": { | ||||||||||||
Type: pluginsdk.TypeString, | ||||||||||||
Required: true, | ||||||||||||
ForceNew: true, | ||||||||||||
ValidateFunc: validate.ApplicationLoadBalancerAssociationName(), | ||||||||||||
}, | ||||||||||||
|
||||||||||||
"application_load_balancer_id": commonschema.ResourceIDReferenceRequiredForceNew(associationsinterface.TrafficControllerId{}), | ||||||||||||
|
||||||||||||
"subnet_id": commonschema.ResourceIDReferenceRequiredForceNew(commonids.SubnetId{}), | ||||||||||||
|
||||||||||||
"tags": commonschema.Tags(), | ||||||||||||
} | ||||||||||||
} | ||||||||||||
|
||||||||||||
func (t ApplicationLoadBalancerAssociationResource) Attributes() map[string]*pluginsdk.Schema { | ||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. etc |
||||||||||||
return map[string]*pluginsdk.Schema{} | ||||||||||||
} | ||||||||||||
|
||||||||||||
func (t ApplicationLoadBalancerAssociationResource) ModelObject() interface{} { | ||||||||||||
return &AssociationResourceModel{} | ||||||||||||
} | ||||||||||||
|
||||||||||||
func (t ApplicationLoadBalancerAssociationResource) ResourceType() string { | ||||||||||||
return "azurerm_application_load_balancer_subnet_association" | ||||||||||||
} | ||||||||||||
|
||||||||||||
func (t ApplicationLoadBalancerAssociationResource) IDValidationFunc() pluginsdk.SchemaValidateFunc { | ||||||||||||
return associationsinterface.ValidateAssociationID | ||||||||||||
} | ||||||||||||
func (t ApplicationLoadBalancerAssociationResource) Create() sdk.ResourceFunc { | ||||||||||||
return sdk.ResourceFunc{ | ||||||||||||
Timeout: 30 * time.Minute, | ||||||||||||
Func: func(ctx context.Context, metadata sdk.ResourceMetaData) error { | ||||||||||||
trafficControllerClient := metadata.Client.ServiceNetworking.TrafficControllerInterface | ||||||||||||
client := metadata.Client.ServiceNetworking.AssociationsInterface | ||||||||||||
|
||||||||||||
var config AssociationResourceModel | ||||||||||||
if err := metadata.Decode(&config); err != nil { | ||||||||||||
return fmt.Errorf("decoding %v", err) | ||||||||||||
} | ||||||||||||
|
||||||||||||
albId, err := trafficcontrollerinterface.ParseTrafficControllerID(config.ApplicationLoadBalancerId) | ||||||||||||
if err != nil { | ||||||||||||
return err | ||||||||||||
} | ||||||||||||
|
||||||||||||
id := associationsinterface.NewAssociationID(albId.SubscriptionId, albId.ResourceGroupName, albId.TrafficControllerName, config.Name) | ||||||||||||
existing, err := client.Get(ctx, id) | ||||||||||||
if err != nil && !response.WasNotFound(existing.HttpResponse) { | ||||||||||||
return fmt.Errorf("checking for presence of exisiting %s: %+v", id, err) | ||||||||||||
} | ||||||||||||
|
||||||||||||
if !response.WasNotFound(existing.HttpResponse) { | ||||||||||||
return metadata.ResourceRequiresImport(t.ResourceType(), id) | ||||||||||||
} | ||||||||||||
|
||||||||||||
controller, err := trafficControllerClient.Get(ctx, *albId) | ||||||||||||
if err != nil { | ||||||||||||
return fmt.Errorf("retrieving parent %s: %+v", *albId, err) | ||||||||||||
} | ||||||||||||
|
||||||||||||
if controller.Model == nil { | ||||||||||||
return fmt.Errorf("retrieving parent %s: model was nil", *albId) | ||||||||||||
} | ||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. here we're assuming we're getting a model back:
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @ziyeqf could you address this comment? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think I have already updated code per this comment? |
||||||||||||
|
||||||||||||
association := associationsinterface.Association{ | ||||||||||||
Location: location.Normalize(controller.Model.Location), | ||||||||||||
Properties: &associationsinterface.AssociationProperties{ | ||||||||||||
Subnet: &associationsinterface.AssociationSubnet{ | ||||||||||||
Id: config.SubnetId, | ||||||||||||
}, | ||||||||||||
AssociationType: associationsinterface.AssociationTypeSubnets, | ||||||||||||
katbyte marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||||||
}, | ||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I cant use it because it returns There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There's two imports for There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. please follow toms advice here @ziyeqf There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm already using |
||||||||||||
Tags: tags.Expand(config.Tags), | ||||||||||||
} | ||||||||||||
|
||||||||||||
if err := client.CreateOrUpdateThenPoll(ctx, id, association); err != nil { | ||||||||||||
return fmt.Errorf("creating %s: %+v", id, err) | ||||||||||||
} | ||||||||||||
|
||||||||||||
metadata.SetID(id) | ||||||||||||
return nil | ||||||||||||
}, | ||||||||||||
} | ||||||||||||
} | ||||||||||||
|
||||||||||||
func (t ApplicationLoadBalancerAssociationResource) Read() sdk.ResourceFunc { | ||||||||||||
return sdk.ResourceFunc{ | ||||||||||||
Timeout: 5 * time.Minute, | ||||||||||||
Func: func(ctx context.Context, metadata sdk.ResourceMetaData) error { | ||||||||||||
client := metadata.Client.ServiceNetworking.AssociationsInterface | ||||||||||||
|
||||||||||||
id, err := associationsinterface.ParseAssociationID(metadata.ResourceData.Id()) | ||||||||||||
if err != nil { | ||||||||||||
return err | ||||||||||||
} | ||||||||||||
|
||||||||||||
resp, err := client.Get(ctx, *id) | ||||||||||||
if err != nil { | ||||||||||||
if response.WasNotFound(resp.HttpResponse) { | ||||||||||||
return metadata.MarkAsGone(id) | ||||||||||||
} | ||||||||||||
return fmt.Errorf("retreiving %s: %v", *id, err) | ||||||||||||
} | ||||||||||||
|
||||||||||||
trafficControllerId := associationsinterface.NewTrafficControllerID(id.SubscriptionId, id.ResourceGroupName, id.TrafficControllerName) | ||||||||||||
state := AssociationResourceModel{ | ||||||||||||
Name: id.AssociationName, | ||||||||||||
ApplicationLoadBalancerId: trafficControllerId.ID(), | ||||||||||||
} | ||||||||||||
|
||||||||||||
if model := resp.Model; model != nil { | ||||||||||||
state.Tags = tags.Flatten(model.Tags) | ||||||||||||
|
||||||||||||
if prop := model.Properties; prop != nil { | ||||||||||||
if prop.Subnet != nil { | ||||||||||||
parsedSubnetId, err := commonids.ParseSubnetIDInsensitively(prop.Subnet.Id) | ||||||||||||
if err != nil { | ||||||||||||
return err | ||||||||||||
} | ||||||||||||
state.SubnetId = parsedSubnetId.ID() | ||||||||||||
} | ||||||||||||
} | ||||||||||||
} | ||||||||||||
|
||||||||||||
return metadata.Encode(&state) | ||||||||||||
}, | ||||||||||||
} | ||||||||||||
} | ||||||||||||
|
||||||||||||
func (t ApplicationLoadBalancerAssociationResource) Update() sdk.ResourceFunc { | ||||||||||||
return sdk.ResourceFunc{ | ||||||||||||
Timeout: 30 * time.Minute, | ||||||||||||
Func: func(ctx context.Context, metadata sdk.ResourceMetaData) error { | ||||||||||||
client := metadata.Client.ServiceNetworking.AssociationsInterface | ||||||||||||
|
||||||||||||
var plan AssociationResourceModel | ||||||||||||
if err := metadata.Decode(&plan); err != nil { | ||||||||||||
return fmt.Errorf("decoding %v", err) | ||||||||||||
} | ||||||||||||
|
||||||||||||
id, err := associationsinterface.ParseAssociationID(metadata.ResourceData.Id()) | ||||||||||||
if err != nil { | ||||||||||||
return err | ||||||||||||
} | ||||||||||||
|
||||||||||||
// Thought `AssociationSubnetUpdate` defined in the SDK contains the `subnetId`, while per testing it can not be updated | ||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @ziyeqf - have you opened an issue yet? could you add it to this comment? and address the question? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. updated the issue link to the code comment. |
||||||||||||
associationUpdate := associationsinterface.AssociationUpdate{} | ||||||||||||
|
||||||||||||
if metadata.ResourceData.HasChange("tags") { | ||||||||||||
associationUpdate.Tags = tags.Expand(plan.Tags) | ||||||||||||
} | ||||||||||||
|
||||||||||||
if _, err = client.Update(ctx, *id, associationUpdate); err != nil { | ||||||||||||
return fmt.Errorf("updating %s: %v", *id, err) | ||||||||||||
} | ||||||||||||
|
||||||||||||
return nil | ||||||||||||
}, | ||||||||||||
} | ||||||||||||
} | ||||||||||||
|
||||||||||||
func (t ApplicationLoadBalancerAssociationResource) Delete() sdk.ResourceFunc { | ||||||||||||
return sdk.ResourceFunc{ | ||||||||||||
Timeout: 30 * time.Minute, | ||||||||||||
Func: func(ctx context.Context, metadata sdk.ResourceMetaData) error { | ||||||||||||
client := metadata.Client.ServiceNetworking.AssociationsInterface | ||||||||||||
|
||||||||||||
id, err := associationsinterface.ParseAssociationID(metadata.ResourceData.Id()) | ||||||||||||
if err != nil { | ||||||||||||
return err | ||||||||||||
} | ||||||||||||
|
||||||||||||
if err = client.DeleteThenPoll(ctx, *id); err != nil { | ||||||||||||
return fmt.Errorf("deleting %s: %v", *id, err) | ||||||||||||
} | ||||||||||||
|
||||||||||||
return nil | ||||||||||||
}, | ||||||||||||
} | ||||||||||||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This filename needs to be updated to reflect the new name?