Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: azurerm_dev_center #23522

Closed
wants to merge 6 commits into from

Conversation

jiaweitao001
Copy link
Contributor

  • All tests passed.

@tombuildsstuff
Copy link
Contributor

hey @jiaweitao001

Thanks for this PR.

Taking a look through here it appears that the DevCenter resources can be generated with hashicorp/pandora, as such rather than defining these by hand we should be able to do that instead.

As such I hope you don't mind but I'm going to close this PR in favour of #23530 (which scaffolds this Service Package to enable generation) and hashicorp/pandora#3152 which'll enable generating both the azurerm_dev_center and azurerm_dev_center_project resources - allowing us to ship this in a slightly different manner.

It's worth noting that there are a couple of Swagger issues present within this Service - I can see in this PR that you've worked around those (by not surfacing those fields), but in future it'd be good to send a PR to fix those issues so that we can expose those fields as required.

Thanks!

@jiaweitao001
Copy link
Contributor Author

hey @jiaweitao001

Thanks for this PR.

Taking a look through here it appears that the DevCenter resources can be generated with hashicorp/pandora, as such rather than defining these by hand we should be able to do that instead.

As such I hope you don't mind but I'm going to close this PR in favour of #23530 (which scaffolds this Service Package to enable generation) and hashicorp/pandora#3152 which'll enable generating both the azurerm_dev_center and azurerm_dev_center_project resources - allowing us to ship this in a slightly different manner.

It's worth noting that there are a couple of Swagger issues present within this Service - I can see in this PR that you've worked around those (by not surfacing those fields), but in future it'd be good to send a PR to fix those issues so that we can expose those fields as required.

Thanks!

Hi @tombuildsstuff , thanks for providing the details. I'm cool with closing this PR. Is there anything I need to do for this resource? Or you're taking over from here?

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants