Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nat_gateway.html.markdown to add ip association examples #23502

Merged

Conversation

ergihu
Copy link
Contributor

@ergihu ergihu commented Oct 10, 2023

The example Terraform code in azurerm_nat_gateway is missing the ways to associate a public IP address or public IP prefix to the NAT gateway.

Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ergihu, thanks for suggesting this. Whilst the example for azurerm_nat_gateway doesn't represent a complete solution, this would be better added to the documentation page for azurerm_nat_gateway_public_ip_association - and indeed that page already has a complete example.

However, you have raised attention to the fact that this example is a bit redundant, and I think it would be a good idea to clean this up. We can also add a link from the azurerm_nat_gateway page to the azurerm_nat_gateway_public_ip_association page, to better assist users seeking a complete example. Doing it this way will make it easier for maintainers as we typically check upstream when looking to update docs, so this is less likely to be overlooked in future.

…ociation and nat_gateway_public_ip_prefix_association resources
@manicminer manicminer merged commit f125e45 into hashicorp:main Oct 10, 2023
4 checks passed
@github-actions github-actions bot added this to the v3.76.0 milestone Oct 10, 2023
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants