`azurerm_log_analytics_cluster`: swap to typed sdk #23373

ziyeqf · 2023-09-25T08:37:56Z

the service has creation limit on this resource, so I'm submitting these changes in one PR.

also, because of the quota limit, I'm going to update test results one by one. Once all finished I will convert it to "ready to review"

test

❯❯ tftest loganalytics TestAccLogAnalyticsCluster_basic
=== RUN   TestAccLogAnalyticsCluster_basic
=== PAUSE TestAccLogAnalyticsCluster_basic
=== CONT  TestAccLogAnalyticsCluster_basic
--- PASS: TestAccLogAnalyticsCluster_basic (1986.40s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/loganalytics	1986.448s

❯❯ tftest loganalytics TestAccLogAnalyticsCluster_resize

=== RUN   TestAccLogAnalyticsCluster_resize
=== PAUSE TestAccLogAnalyticsCluster_resize
=== CONT  TestAccLogAnalyticsCluster_resize
--- PASS: TestAccLogAnalyticsCluster_resize (2737.96s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/loganalytics	2738.017s
❯❯ tftest loganalytics TestAccLogAnalyticsCluster_requiresImport
=== RUN   TestAccLogAnalyticsCluster_requiresImport
=== PAUSE TestAccLogAnalyticsCluster_requiresImport
=== CONT  TestAccLogAnalyticsCluster_requiresImport
--- PASS: TestAccLogAnalyticsCluster_requiresImport (2567.62s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/loganalytics	2567.681s

ziyeqf · 2023-11-10T06:35:15Z

The service has a quota limit on cluster creation which makes my test progress slow..

magodo · 2023-12-25T07:20:46Z

internal/services/loganalytics/log_analytics_cluster_customer_managed_key_resource.go

@@ -58,6 +60,12 @@ func resourceLogAnalyticsClusterCustomerManagedKey() *pluginsdk.Resource {
 				Required:     true,
 				ValidateFunc: keyVaultValidate.NestedItemIdWithOptionalVersion,
 			},
+
+			"key_rsa_size": {


Can we split this into its own PR?

Because the quota limit of the service split these into different PRs will cost a very long time to run these tests..

magodo · 2023-12-25T07:21:10Z

internal/services/loganalytics/log_analytics_cluster_customer_managed_key_resource_test.go

@@ -9,7 +9,7 @@ import (
 	"os"
 	"testing"

-	"github.com/hashicorp/go-azure-sdk/resource-manager/operationalinsights/2020-08-01/clusters"


Can we move this API upgrade to its own PR?

internal/services/loganalytics/log_analytics_cluster_resource.go

ziyeqf · 2023-12-26T05:45:25Z

closed by mistake

magodo

Thanks for this PR!
I've taken a look through and left some comments inline, but this is mostly looking good to me 👍

magodo · 2023-12-27T01:08:09Z

.gitignore

@@ -53,3 +53,7 @@ tf.zip

 # do not upload secrets
 .env
+
+# custom for myself
+.gitignore


Can we avoid to check in this?

magodo · 2023-12-27T01:09:13Z

internal/services/loganalytics/log_analytics_cluster_resource.go


-			"tags": tags.Schema(),
+		"availability_zones_enabled": {


Is this introduced by a mistake?

magodo · 2023-12-27T01:11:44Z

internal/services/loganalytics/log_analytics_cluster_resource.go


-	if d.HasChange("size_gb") && model.Sku != nil && model.Sku.Capacity != nil {


This seems is missing in the new update function?

ziyeqf · 2023-12-27T02:29:53Z

The service might have some issue these days, creating new clusters always get HTTP 500, will append new test results once the service healthy

tombuildsstuff · 2024-03-19T14:58:32Z

@ziyeqf as this PR's been sitting as a draft since September with no update since December I'm going to temporary close this PR for the moment - but once you're able to test this please let us know and we can reopen this/take another look.

Thanks!

ziyeqf · 2024-03-25T03:25:37Z

Hi @tombuildsstuff, this was blocked by a issue on the service before. The issue is gone and I have run the tests successfully. Can we reopen this PR?

tombuildsstuff · 2024-03-25T09:26:59Z

@ziyeqf so is this no longer a WIP?

ziyeqf · 2024-03-25T10:35:11Z

@ziyeqf so is this no longer a WIP?

Yes, it's ready for review.

katbyte

LGTM 🧊

ziyeqf · 2024-04-15T05:19:51Z

kindly ping for merging

<Actions> <action id="f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8"> <h3>Bump Terraform `azurerm` provider version</h3> <details id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24"> <summary>Update Terraform lock file</summary> <p>changes detected:
	"hashicorp/azurerm" updated from "3.99.0" to "3.100.0" in file ".terraform.lock.hcl"</p> <details> <summary>3.100.0</summary> <pre>Changelog retrieved from:
	https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.100.0
ENHANCEMENTS:

* dependencies: updating `hashicorp/go-azure-sdk` to `v0.20240417.1084633` ([#25659](hashicorp/terraform-provider-azurerm#25659 `compute` - update Virtual Machine and Virtual Machine Scale Set resources and data sources to use `hashicorp/go-azure-sdk` ([#25533](hashicorp/terraform-provider-azurerm#25533 `machine_learning` - Add new `machine_learning` block that supports `purge_soft_deleted_workspace_on_destroy` ([#25624](hashicorp/terraform-provider-azurerm#25624 `loganalytics` - update cluster resource to use `hashicorp/go-azure-sdk` ([#23373](hashicorp/terraform-provider-azurerm#23373 Data Source: `azurerm_management_group` - now exports the `tenant_scoped_id` attribute ([#25555](hashicorp/terraform-provider-azurerm#25555 `azurerm_container_app` - the `ingress.ip_security_restriction.ip_address_range` property will now accept an IP address as valid input ([#25609](hashicorp/terraform-provider-azurerm#25609 `azurerm_container_group` - the `identity` block can now be updated ([#25543](hashicorp/terraform-provider-azurerm#25543 `azurerm_express_route_connection` - support for the `private_link_fast_path_enabled` property ([#25596](hashicorp/terraform-provider-azurerm#25596 `azurerm_hdinsight_hadoop_cluster` - support for the `private_link_configuration` block ([#25629](hashicorp/terraform-provider-azurerm#25629 `azurerm_hdinsight_hbase_cluster` - support for the `private_link_configuration` block ([#25629](hashicorp/terraform-provider-azurerm#25629 `azurerm_hdinsight_interactive_query_cluster` - support for the `private_link_configuration` block ([#25629](hashicorp/terraform-provider-azurerm#25629 `azurerm_hdinsight_kafka_cluster` - support for the `private_link_configuration` block ([#25629](hashicorp/terraform-provider-azurerm#25629 `azurerm_hdinsight_spark_cluster` - support for the `private_link_configuration` block ([#25629](hashicorp/terraform-provider-azurerm#25629 `azurerm_management_group` - now exports the `tenant_scoped_id` attribute ([#25555](hashicorp/terraform-provider-azurerm#25555 `azurerm_monitor_activity_log_alert` - support for the `location` property ([#25389](hashicorp/terraform-provider-azurerm#25389 `azurerm_mysql_flexible_server` - update validating regex for `sku_name` ([#25642](hashicorp/terraform-provider-azurerm#25642 `azurerm_postgresql_flexible_server` - support for the `GeoRestore` `create_mode` ([#25664](hashicorp/terraform-provider-azurerm#25664 `azurerm_virtual_network_gateway_connection` - support for the `private_link_fast_path_enabled` property ([#25650](hashicorp/terraform-provider-azurerm#25650 `azurerm_windows_web_app` - support for the `handler_mapping` block ([#25631](hashicorp/terraform-provider-azurerm#25631 `azurerm_windows_web_app_slot` - support for the `handler_mapping` block ([#25631](https://github.com/hashicorp/terraform-provider-azurerm/issues/25631))

BUG FIXES:

* storage: prevent a bug causing the second storage account key to be used for authentication instead of the first ([#25652](hashicorp/terraform-provider-azurerm#25652 `azurerm_active_directory_domain_service` - prevent an issue where `filtered_sync_enabled` was not being updated ([#25594](hashicorp/terraform-provider-azurerm#25594 `azurerm_application_insights` - add a state migration to fix the resource ID casing of Application Insights resources ([#25628](hashicorp/terraform-provider-azurerm#25628 `azurerm_function_app_hybrid_connection` - can now use relay resources created in a different resource group ([#25541](hashicorp/terraform-provider-azurerm#25541 `azurerm_kubernetes_cluster_node_pool` - prevent plan diff when the `windows_profile.outbound_nat_enabled` property is unset ([#25644](hashicorp/terraform-provider-azurerm#25644 `azurerm_machine_learning_compute_cluster` - fix location to point to parent resource for computes ([#25643](hashicorp/terraform-provider-azurerm#25643 `azurerm_machine_learning_compute_instance` - fix location to point to parent resource for computes ([#25643](hashicorp/terraform-provider-azurerm#25643 `azurerm_storage_account` - check replication type when evaluating support level for shares and queues for V1 storage accounts ([#25581](hashicorp/terraform-provider-azurerm#25581 `azurerm_storage_account` - added a sanity check for `dns_endpoint_type` and `blob_properties.restore_policy` ([#25450](hashicorp/terraform-provider-azurerm#25450 `azurerm_web_app_hybrid_connection` - can now use relay resources created in a different resource group ([#25541](hashicorp/terraform-provider-azurerm#25541 `azurerm_windows_web_app` - prevent removal of `site_config.application_stack.node_version` when `app_settings` are updated ([#25488](hashicorp/terraform-provider-azurerm#25488 `azurerm_windows_web_app_slot` - prevent removal of `site_config.application_stack.node_version` when `app_settings` are updated ([#25489](https://github.com/hashicorp/terraform-provider-azurerm/issues/25489))

DEPRECATIONS:

* `logz` - the Logz resources are deprecated and will be removed in v4.0 of the AzureRM Provider since the API no longer allows new instances to be created ([#25405](hashicorp/terraform-provider-azurerm#25405 `azurerm_machine_learning_compute_instance` - marked the `location` field as deprecated in v4.0 of the provider ([#25643](hashicorp/terraform-provider-azurerm#25643 `azurerm_kubernetes_cluster` - the following properties have been deprecated since the API no longer supports cluster creation with legacy Azure Entra integration: `client_app_id`, `server_app_id`, `server_app_secret` and `managed` ([#25200](https://github.com/hashicorp/terraform-provider-azurerm/issues/25200))


</pre> </details> </details> <a href="https://infra.ci.jenkins.io/job/updatecli/job/azure/job/main/117/">Jenkins pipeline link</a> </action> </Actions> --- <table> <tr> <td width="77"> <img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli logo" width="50" height="50"> </td> <td> <p> Created automatically by <a href="https://www.updatecli.io/">Updatecli</a> </p> <details><summary>Options:</summary> <br /> <p>Most of Updatecli configuration is done via <a href="https://www.updatecli.io/docs/prologue/quick-start/">its manifest(s)</a>.</p> <ul> <li>If you close this pull request, Updatecli will automatically reopen it, the next time it runs.</li> <li>If you close this pull request and delete the base branch, Updatecli will automatically recreate it, erasing all previous commits made.</li> </ul> <p> Feel free to report any issues at <a href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br /> If you find this tool useful, do not hesitate to star <a href="https://github.com/updatecli/updatecli/stargazers">our GitHub repository</a> as a sign of appreciation, and/or to tell us directly on our <a href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>! </p> </details> </td> </tr> </table> Co-authored-by: Jenkins Infra Bot (updatecli) <[email protected]>

github-actions · 2024-05-23T02:08:08Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions bot added dependencies service/log-analytics size/XL waiting-response documentation and removed waiting-response labels Sep 25, 2023

ziyeqf force-pushed the tengzh/vanguard/operationalinsights/cluster branch from 2d6baa3 to 7bf2710 Compare September 26, 2023 06:48

github-actions bot removed the waiting-response label Sep 26, 2023

ziyeqf force-pushed the tengzh/vanguard/operationalinsights/cluster branch from 75cba04 to 8955992 Compare November 16, 2023 06:43

github-actions bot added waiting-response and removed waiting-response labels Nov 16, 2023

github-actions bot added waiting-response and removed waiting-response labels Dec 1, 2023

ziyeqf force-pushed the tengzh/vanguard/operationalinsights/cluster branch from 5217d62 to a48a992 Compare December 1, 2023 07:09

github-actions bot removed the waiting-response label Dec 1, 2023

tombuildsstuff added the waiting-response label Dec 7, 2023

magodo requested changes Dec 25, 2023

View reviewed changes

ziyeqf changed the title ~~azurerm_log_analytics_cluster: swap to typed sdk & support user assigned identity & billing_type & availability_zones_enabled & double_encryption_enabled~~ azurerm_log_analytics_cluster: swap to typed sdk Dec 26, 2023

ziyeqf closed this Dec 26, 2023

ziyeqf force-pushed the tengzh/vanguard/operationalinsights/cluster branch from a48a992 to 46a95c1 Compare December 26, 2023 05:37

github-actions bot added size/XS and removed waiting-response size/XL labels Dec 26, 2023

azurerm_log_analytics_cluster: swap to typed sdk

9c15af6

ziyeqf reopened this Dec 26, 2023

github-actions bot added size/XL and removed size/XS labels Dec 26, 2023

refresh vendor

d4f4d4f

github-actions bot added the waiting-response label Dec 26, 2023

magodo requested changes Dec 27, 2023

View reviewed changes

update code

1b7f371

github-actions bot removed the waiting-response label Dec 27, 2023

Merge branch 'main' into tengzh/vanguard/operationalinsights/cluster

ed3728f

tombuildsstuff closed this Mar 19, 2024

Merge branch 'main' into tengzh/vanguard/operationalinsights/cluster

8970428

tombuildsstuff reopened this Mar 25, 2024

ziyeqf marked this pull request as ready for review March 25, 2024 10:34

katbyte approved these changes Apr 9, 2024

View reviewed changes

stephybun merged commit 09bc86a into hashicorp:main Apr 18, 2024
31 checks passed

github-actions bot added this to the v3.100.0 milestone Apr 18, 2024

stephybun added a commit that referenced this pull request Apr 18, 2024

Update for #23373

b0535bd

ziyeqf deleted the tengzh/vanguard/operationalinsights/cluster branch April 22, 2024 02:07

github-actions bot locked as resolved and limited conversation to collaborators May 23, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`azurerm_log_analytics_cluster`: swap to typed sdk #23373

`azurerm_log_analytics_cluster`: swap to typed sdk #23373

ziyeqf commented Sep 25, 2023 •

edited

Loading

ziyeqf commented Nov 10, 2023 •

edited

Loading

magodo Dec 25, 2023

ziyeqf Dec 25, 2023

magodo Dec 25, 2023

ziyeqf commented Dec 26, 2023

magodo left a comment

magodo Dec 27, 2023

magodo Dec 27, 2023

magodo Dec 27, 2023

ziyeqf commented Dec 27, 2023

tombuildsstuff commented Mar 19, 2024

ziyeqf commented Mar 25, 2024 •

edited

Loading

tombuildsstuff commented Mar 25, 2024

ziyeqf commented Mar 25, 2024 •

edited

Loading

katbyte left a comment

ziyeqf commented Apr 15, 2024

github-actions bot commented May 23, 2024


		if d.HasChange("size_gb") && model.Sku != nil && model.Sku.Capacity != nil {

azurerm_log_analytics_cluster: swap to typed sdk #23373

azurerm_log_analytics_cluster: swap to typed sdk #23373

Conversation

ziyeqf commented Sep 25, 2023 • edited Loading

test

ziyeqf commented Nov 10, 2023 • edited Loading

magodo Dec 25, 2023

Choose a reason for hiding this comment

ziyeqf Dec 25, 2023

Choose a reason for hiding this comment

magodo Dec 25, 2023

Choose a reason for hiding this comment

ziyeqf commented Dec 26, 2023

magodo left a comment

Choose a reason for hiding this comment

magodo Dec 27, 2023

Choose a reason for hiding this comment

magodo Dec 27, 2023

Choose a reason for hiding this comment

magodo Dec 27, 2023

Choose a reason for hiding this comment

ziyeqf commented Dec 27, 2023

tombuildsstuff commented Mar 19, 2024

ziyeqf commented Mar 25, 2024 • edited Loading

tombuildsstuff commented Mar 25, 2024

ziyeqf commented Mar 25, 2024 • edited Loading

katbyte left a comment

Choose a reason for hiding this comment

ziyeqf commented Apr 15, 2024

github-actions bot commented May 23, 2024

`azurerm_log_analytics_cluster`: swap to typed sdk #23373

`azurerm_log_analytics_cluster`: swap to typed sdk #23373

ziyeqf commented Sep 25, 2023 •

edited

Loading

ziyeqf commented Nov 10, 2023 •

edited

Loading

ziyeqf commented Mar 25, 2024 •

edited

Loading

ziyeqf commented Mar 25, 2024 •

edited

Loading