Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_recovery_services_vault_resource_guard_association: fix acctest #23301

Merged
merged 2 commits into from
Sep 19, 2023

Conversation

ziyeqf
Copy link
Contributor

@ziyeqf ziyeqf commented Sep 18, 2023

The service start to return error if the name is not VaultProxy.
While removing the property will bring breaking change.

test

❯ tftest recoveryservices TestAccSiteRecoveryVaultResourceGuardAssociation_basic 
=== RUN   TestAccSiteRecoveryVaultResourceGuardAssociation_basic
=== PAUSE TestAccSiteRecoveryVaultResourceGuardAssociation_basic
=== CONT  TestAccSiteRecoveryVaultResourceGuardAssociation_basic
--- PASS: TestAccSiteRecoveryVaultResourceGuardAssociation_basic (316.99s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/recoveryservices      317.046s

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a TODO comment above the property in the resource to remove this in 4.0 and default the name to VaultProxy?

Signed-off-by: ziyeqf <[email protected]>
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ziyeqf LGTM 👍

@stephybun stephybun added the bug label Sep 19, 2023
@stephybun stephybun merged commit 4d9e601 into hashicorp:main Sep 19, 2023
23 checks passed
@ziyeqf ziyeqf deleted the tengzh/acctest/resource_guard branch September 19, 2023 05:34
@github-actions github-actions bot added this to the v3.74.0 milestone Sep 19, 2023
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants